-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a read-only FSFile.fs property #2832
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 366 366
Lines 53522 53531 +9
=======================================
+ Hits 51350 51359 +9
Misses 2172 2172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9584991230Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9592336810Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR exposes the private
FSFile._fs
via a read-only property which would be nicer than accessing the private attribute. I'll need this for usingfsspec
caching I'm adding to Trollflow2 in pytroll/trollflow2#205AUTHORS.md
if not there already