Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a read-only FSFile.fs property #2832

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Jun 19, 2024

This PR exposes the private FSFile._fs via a read-only property which would be nicer than accessing the private attribute. I'll need this for using fsspec caching I'm adding to Trollflow2 in pytroll/trollflow2#205

  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@pnuu pnuu added enhancement code enhancements, features, improvements component:readers labels Jun 19, 2024
@pnuu pnuu self-assigned this Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (aff4f31) to head (52953f6).
Report is 332 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2832   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         366      366           
  Lines       53522    53531    +9     
=======================================
+ Hits        51350    51359    +9     
  Misses       2172     2172           
Flag Coverage Δ
behaviourtests 4.04% <18.18%> (+<0.01%) ⬆️
unittests 96.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9584991230

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 96.041%

Totals Coverage Status
Change from base Build 9520945640: 0.001%
Covered Lines: 51572
Relevant Lines: 53698

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9592336810

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 96.042%

Totals Coverage Status
Change from base Build 9588363290: 0.001%
Covered Lines: 51588
Relevant Lines: 53714

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 8dfc261 into pytroll:main Jun 20, 2024
18 of 19 checks passed
@pnuu pnuu deleted the fsfile-public-fs-property branch June 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants