Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow on-the-fly decompression of xRIT files in xRIT readers #436

Merged
merged 14 commits into from
Nov 23, 2018

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 1, 2018

This PR add on-the-fly decompression for xRIT files if the XRIT_DECOMPRESS_PATH environment variable is specified.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

@coveralls
Copy link

coveralls commented Oct 1, 2018

Coverage Status

Coverage increased (+1.6%) to 74.355% when pulling d03dd73 on feature-hrit-decompress into 1d3b128 on master.

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #436 into master will decrease coverage by 1.53%.
The diff coverage is 84.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   74.31%   72.78%   -1.54%     
==========================================
  Files         136      131       -5     
  Lines       18188    17547     -641     
==========================================
- Hits        13517    12771     -746     
- Misses       4671     4776     +105
Impacted Files Coverage Δ
satpy/readers/hrit_electrol.py 34.42% <100%> (ø) ⬆️
satpy/readers/hrit_goes.py 51.65% <100%> (ø) ⬆️
satpy/readers/hrit_msg.py 21.46% <100%> (-23.17%) ⬇️
satpy/readers/hrit_jma.py 97.67% <100%> (ø) ⬆️
satpy/readers/hrit_base.py 79.5% <76%> (-1.92%) ⬇️
satpy/tests/reader_tests/test_hrit_base.py 93.87% <94.11%> (+0.03%) ⬆️
satpy/readers/nc_olci.py 22.72% <0%> (-19.81%) ⬇️
satpy/readers/nc_nwcsaf.py 17.02% <0%> (-19.17%) ⬇️
satpy/composites/__init__.py 32.78% <0%> (-8.37%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7b3bc5...5437d9c. Read the comment docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. You removed the pattern so compressed files aren't going to be matched anymore, right?

satpy/readers/hrit_base.py Outdated Show resolved Hide resolved
satpy/readers/hrit_base.py Show resolved Hide resolved
@mraspaud mraspaud merged commit b2ecc65 into master Nov 23, 2018
@mraspaud mraspaud deleted the feature-hrit-decompress branch November 23, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants