Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving a dataset with a prerequisites attrs to netcdf #448

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 8, 2018

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@coveralls
Copy link

coveralls commented Oct 8, 2018

Coverage Status

Coverage decreased (-0.004%) to 72.962% when pulling 0750e5c on fix-nc-writer-prereqs into 2f45b54 on master.

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #448 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   72.96%   73.11%   +0.14%     
==========================================
  Files         134      134              
  Lines       17689    17789     +100     
==========================================
+ Hits        12907    13006      +99     
- Misses       4782     4783       +1
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_cf.py 97.89% <100%> (+0.06%) ⬆️
satpy/writers/cf_writer.py 68.18% <100%> (+0.73%) ⬆️
satpy/tests/test_readers.py 98.82% <0%> (+0.3%) ⬆️
satpy/tests/reader_tests/test_hdf5_utils.py 93.47% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f45b54...0750e5c. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Oct 16, 2018

@mraspaud Ready for merge? Feel free to merge it.

@mraspaud mraspaud merged commit 9062fb7 into master Oct 16, 2018
@mraspaud mraspaud deleted the fix-nc-writer-prereqs branch October 16, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants