Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a first version on how to write a custom reader #489

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Nov 5, 2018

  • Fully documented

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe be added to the developer's guide section? Or a separate page as a whole? This main readers page could still reference the other page. Thoughts?

@coveralls
Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage increased (+0.2%) to 74.13% when pulling c490b5b on mraspaud:doc-custom-reader into 5dd28ea on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #489 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   73.93%   74.13%   +0.19%     
==========================================
  Files         137      137              
  Lines       18222    18257      +35     
==========================================
+ Hits        13472    13534      +62     
+ Misses       4750     4723      -27
Impacted Files Coverage Δ
satpy/config.py 46.66% <0%> (-24.49%) ⬇️
satpy/scene.py 84.03% <0%> (-0.43%) ⬇️
satpy/tests/test_scene.py 99.32% <0%> (-0.01%) ⬇️
satpy/composites/viirs.py 84.09% <0%> (ø) ⬆️
satpy/tests/test_enhancements.py 98.55% <0%> (ø) ⬆️
satpy/readers/hrit_msg.py 44.63% <0%> (ø) ⬆️
satpy/writers/geotiff.py 43.51% <0%> (ø) ⬆️
satpy/readers/abi_l1b.py 96.66% <0%> (+0.02%) ⬆️
satpy/readers/iasi_l2.py 98.8% <0%> (+0.02%) ⬆️
satpy/tests/test_writers.py 97.31% <0%> (+0.11%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd28ea...5d024fa. Read the comment docs.

@mraspaud mraspaud merged commit a7b3bc5 into pytroll:master Nov 22, 2018
@mraspaud mraspaud deleted the doc-custom-reader branch November 22, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants