Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radiance units of geostationary satellites #490

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Nov 7, 2018

Fix radiance units of geostationary satellites and add references where missing. Now the value ranges of SEVIRI, ABI and AHI radiances are consistent (taking into account that toa_radiance_per_unit_wavenumber = wavelength^2 * toa_radiance_per_unit_wavelength).

Also include links to the references.
@djhoese
Copy link
Member

djhoese commented Nov 7, 2018

Why is this needed? You've also changed the units for ABI that are specified in the file as:

Rad:units = "W m-2 sr-1 um-1" ;

Are your units equivalent?

@sfinkens
Copy link
Member Author

sfinkens commented Nov 7, 2018

For channels 1-6 the units are indeed W m-2 um-1 sr-1. But for channels 7-16 it is mW m-2 sr-1 (cm-1)-1, also in the files. See the GOES-R Data Book, page 3-2.

@djhoese
Copy link
Member

djhoese commented Nov 7, 2018

You got me there. Thanks for the clarification. So AHI doesn't follow the same pattern?

@djhoese
Copy link
Member

djhoese commented Nov 7, 2018

If the test failures don't seem like your fault then don't worry about it. This is a bug with the conda-forge package of imageio that I've been debugging for the last day. A fix should be coming out in the next day or so and we can rerun these tests.

@sfinkens
Copy link
Member Author

sfinkens commented Nov 7, 2018

Rows 8 & 9 in the table on page 14 of the AHI User Guide indicate that they use the same units for all channels. ABI seems to be the only instrument with varying radiance units.

Regarding the test failure: Ok, let's wait for the fix.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 73.911% when pulling 033b719 on sfinkens:fix-geos-radiance-units into 5dd28ea on pytroll:master.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad the coverage went down just because documentation was added. Thanks for looking in to this.

@djhoese djhoese merged commit ba521bf into pytroll:master Nov 9, 2018
@sfinkens sfinkens deleted the fix-geos-radiance-units branch November 12, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants