Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AHI HRIT file patterns so area's ID is correct #550

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 14, 2018

This is a fix after #524 where JMA-based file patterns need to have an area pattern to have the produced AreaDefinition with the proper name. In the ahi_hrit reader this was not done and the area id was UNKNOWN instead of the desired FLDK.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.694% when pulling 454cb19 on djhoese:bugfix-ahi-area into 49027e8 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   76.69%   76.69%           
=======================================
  Files         136      136           
  Lines       18961    18961           
=======================================
  Hits        14542    14542           
  Misses       4419     4419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49027e8...454cb19. Read the comment docs.

@djhoese djhoese merged commit 129cba2 into pytroll:master Dec 14, 2018
@djhoese djhoese deleted the bugfix-ahi-area branch December 14, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants