Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old reader names so they produce an exception #597

Merged
merged 5 commits into from
Mar 14, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 28, 2019

To prolong the deprecation cycle for old reader names @mraspaud and I have decided that we would extend how long old reader names could be used in SatPy. This is mainly due to our decision to be on a 4-6 week release schedule. Too fast for most users.

Old reader names will be completely removed in version 0.15.

@djhoese djhoese added component:readers backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Jan 28, 2019
@djhoese djhoese added this to the v0.13 milestone Jan 28, 2019
@djhoese djhoese self-assigned this Jan 28, 2019
@coveralls
Copy link

coveralls commented Jan 28, 2019

Coverage Status

Coverage decreased (-0.01%) to 78.385% when pulling 40b0c93 on djhoese:deprecate-old-reader-exception into bc5ba34 on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #597 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   78.39%   78.38%   -0.02%     
==========================================
  Files         138      138              
  Lines       19980    19968      -12     
==========================================
- Hits        15664    15652      -12     
  Misses       4316     4316
Impacted Files Coverage Δ
satpy/tests/test_readers.py 98.36% <100%> (-0.05%) ⬇️
satpy/readers/__init__.py 95.1% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5ba34...40b0c93. Read the comment docs.

# Conflicts:
#	satpy/readers/__init__.py
@djhoese djhoese merged commit ee02de0 into pytroll:master Mar 14, 2019
@djhoese djhoese deleted the deprecate-old-reader-exception branch March 14, 2019 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:readers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants