Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix masked resampling when dataset dtype is integer #662

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 15, 2019

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense I think.

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #662 into master will increase coverage by 0.02%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   78.61%   78.63%   +0.02%     
==========================================
  Files         138      138              
  Lines       20325    20332       +7     
==========================================
+ Hits        15979    15989      +10     
+ Misses       4346     4343       -3
Impacted Files Coverage Δ
satpy/tests/test_resample.py 98.91% <100%> (+0.01%) ⬆️
satpy/resample.py 88.02% <75%> (-0.18%) ⬇️
satpy/readers/__init__.py 94.54% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6e5a0...c383dbd. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 78.616% when pulling c383dbd on mraspaud:fix-resample-int-mask into be6e5a0 on pytroll:master.

@coveralls
Copy link

coveralls commented Mar 15, 2019

Coverage Status

Coverage increased (+0.02%) to 78.635% when pulling c383dbd on mraspaud:fix-resample-int-mask into be6e5a0 on pytroll:master.

@mraspaud mraspaud merged commit 757a052 into pytroll:master Mar 15, 2019
@mraspaud mraspaud deleted the fix-resample-int-mask branch March 15, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants