Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use platform ID to choose the right reader for AVHRR GAC data #674

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 25, 2019

Using platform ID, we can skip reading the file at the init stage altogether.

  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Mar 25, 2019
@mraspaud mraspaud self-assigned this Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #674 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   78.66%   78.66%   -0.01%     
==========================================
  Files         138      138              
  Lines       20356    20357       +1     
==========================================
  Hits        16013    16013              
- Misses       4343     4344       +1
Impacted Files Coverage Δ
satpy/readers/avhrr_l1b_gaclac.py 8.33% <0%> (-0.18%) ⬇️
satpy/writers/geotiff.py 42.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a0dcd...f4f5cdb. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 25, 2019

Coverage Status

Coverage decreased (-0.02%) to 78.641% when pulling f4f5cdb on mraspaud:fix-gac-reader into 40a0dcd on pytroll:master.

@mraspaud mraspaud merged commit 0e5236f into pytroll:master Mar 26, 2019
@mraspaud mraspaud deleted the fix-gac-reader branch March 26, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants