Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VIIRS SDR reading of visible channels at nighttime #693

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 3, 2019

Since #538, we are depending on the number of scans being read from the files to create the datasets at read time. However, the variable read in that PR is set to a no-data value for visible channels at nighttime.

This PR fixes the problem by accessing another metadata attribute providing a reliable number of scans, even at night time.

@TAlonglong
Copy link
Collaborator

Thanks.

Yes this works for me on the data that failed previously.

@mraspaud mraspaud requested a review from djhoese April 3, 2019 12:14
@mraspaud mraspaud marked this pull request as ready for review April 3, 2019 12:30
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #693 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   79.14%   79.15%   +<.01%     
==========================================
  Files         140      140              
  Lines       20767    20774       +7     
==========================================
+ Hits        16436    16443       +7     
  Misses       4331     4331
Impacted Files Coverage Δ
satpy/readers/viirs_sdr.py 85.02% <100%> (+0.27%) ⬆️
satpy/tests/reader_tests/test_viirs_sdr.py 92.3% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc5f10...a891d74. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 3, 2019

Coverage Status

Coverage increased (+0.007%) to 79.152% when pulling a891d74 on mraspaud:fix-viirs-visible-night into 3fc5f10 on pytroll:master.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 7d1a89d into pytroll:master Apr 3, 2019
@mraspaud mraspaud deleted the fix-viirs-visible-night branch April 3, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdr_viirs_l1b reader fails in 0.13, recent master, Works with version 0.12.0
4 participants