-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify release instructions #701
Conversation
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 79.31% 79.68% +0.36%
==========================================
Files 145 145
Lines 21120 21191 +71
==========================================
+ Hits 16752 16886 +134
+ Misses 4368 4305 -63
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Thanks. Had a couple comments and one needed fix.
I removed the |
This PR clarifies the release instructions. The previous version didn't explain which
username
should be given, and neither did it tell to add the contents ofCHANGELOG.temp
toCHANGELOG.md
before commit. And the version numbers in steps 4. and 5. were 14 minor and 45 patch releases apart.