Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify release instructions #701

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Apr 8, 2019

This PR clarifies the release instructions. The previous version didn't explain which username should be given, and neither did it tell to add the contents of CHANGELOG.temp to CHANGELOG.md before commit. And the version numbers in steps 4. and 5. were 14 minor and 45 patch releases apart.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #701 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   79.31%   79.68%   +0.36%     
==========================================
  Files         145      145              
  Lines       21120    21191      +71     
==========================================
+ Hits        16752    16886     +134     
+ Misses       4368     4305      -63
Impacted Files Coverage Δ
satpy/tests/compositor_tests/__init__.py 99.34% <0%> (+0.01%) ⬆️
satpy/tests/reader_tests/test_ahi_hsd.py 97.54% <0%> (+0.48%) ⬆️
satpy/readers/ahi_hsd.py 96.87% <0%> (+22.4%) ⬆️
satpy/composites/cloud_products.py 89.06% <0%> (+36.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e35059...af0a04c. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage increased (+0.4%) to 79.685% when pulling af0a04c on pnuu:fix-clarify-releasing into 3e35059 on pytroll:master.

@pnuu pnuu requested review from djhoese and mraspaud April 8, 2019 10:22
@pnuu pnuu self-assigned this Apr 8, 2019
@pnuu pnuu added documentation enhancement code enhancements, features, improvements labels Apr 8, 2019
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks. Had a couple comments and one needed fix.

RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Show resolved Hide resolved
RELEASING.md Show resolved Hide resolved
@djhoese djhoese removed the enhancement code enhancements, features, improvements label Apr 8, 2019
@djhoese
Copy link
Member

djhoese commented Apr 8, 2019

I removed the enhancement label since that should probably be limited to code enhancements/features. I'll update the label description now.

@djhoese djhoese merged commit f83e6b0 into pytroll:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants