Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for mersi2/abi/ahi using bidirection instead of bidirectional #770

Merged
merged 1 commit into from
May 16, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 16, 2019

standard_name for ABI, AHI, MERSI-2 L1B I had a typo of toa_bidirection_reflectance when it should be toa_bidirectional_reflectance (note the al). This fixes this typo.

  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@djhoese djhoese added the bug label May 16, 2019
@djhoese djhoese requested a review from mraspaud May 16, 2019 20:53
@djhoese djhoese self-assigned this May 16, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.842% when pulling 2470d07 on djhoese:bugfix-bidirection-typo into 7fe50a7 on pytroll:master.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #770 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files         158      158           
  Lines       22728    22728           
=======================================
  Hits        18601    18601           
  Misses       4127     4127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe50a7...2470d07. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit e3714c8 into pytroll:master May 16, 2019
@djhoese djhoese deleted the bugfix-bidirection-typo branch May 17, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants