Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader for Hydrology SAF precipitation products #814

Merged
merged 17 commits into from
Jun 13, 2019
Merged

Reader for Hydrology SAF precipitation products #814

merged 17 commits into from
Jun 13, 2019

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Jun 11, 2019

This PR adds support for the EUMETSAT Hydrology SAF precipitation products. Specifically, the reader functions with the h03 and h03B products (instantaneous precipitation) and the h05 and h05B products (accumulated precipitation).
Other H-SAF products are not supported at this time.

An example: H-SAF instantaneous precipitation (h03B product) for Kenya.
HSAF

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 82.808% when pulling 0900b80 on simonrp84:h_saf into 8237e1b on pytroll:master.

@coveralls
Copy link

coveralls commented Jun 11, 2019

Coverage Status

Coverage increased (+0.03%) to 83.63% when pulling ed6cacf on simonrp84:h_saf into fa0e046 on pytroll:master.

satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #814 into master will increase coverage by 0.03%.
The diff coverage is 87.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   83.59%   83.63%   +0.03%     
==========================================
  Files         165      167       +2     
  Lines       24313    24490     +177     
==========================================
+ Hits        20325    20482     +157     
- Misses       3988     4008      +20
Impacted Files Coverage Δ
satpy/tests/reader_tests/__init__.py 98.07% <100%> (+0.03%) ⬆️
satpy/readers/hsaf_grib.py 83.33% <83.33%> (ø)
satpy/tests/reader_tests/test_hsaf_grib.py 91.3% <91.3%> (ø)
satpy/scene.py 90.19% <0%> (+0.17%) ⬆️
satpy/readers/avhrr_l1b_gaclac.py 91.54% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0e046...ed6cacf. Read the comment docs.

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Jun 12, 2019
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding hsaf products to satpy ! A couple of authors should be removed from the header. Also, I think we should rename the reader hsaf_grib for completeness.
Last thing for now, maybe pygrib should be added to setup.py, in the extra dependencies ?

satpy/readers/hsaf.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/__init__.py Outdated Show resolved Hide resolved
@mraspaud
Copy link
Member

@simonrp84 could you add a couple of images to the PR description for completeness and documentation ?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there !

satpy/tests/reader_tests/__init__.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_hsaf_grib.py Show resolved Hide resolved
@mraspaud mraspaud merged commit 4f63df8 into pytroll:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants