-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader for Hydrology SAF precipitation products #814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
+ Coverage 83.59% 83.63% +0.03%
==========================================
Files 165 167 +2
Lines 24313 24490 +177
==========================================
+ Hits 20325 20482 +157
- Misses 3988 4008 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding hsaf products to satpy ! A couple of authors should be removed from the header. Also, I think we should rename the reader hsaf_grib
for completeness.
Last thing for now, maybe pygrib should be added to setup.py, in the extra dependencies ?
@simonrp84 could you add a couple of images to the PR description for completeness and documentation ? |
…R copy to resolve conflict.
…R copy to resolve conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there !
This PR adds support for the EUMETSAT Hydrology SAF precipitation products. Specifically, the reader functions with the h03 and h03B products (instantaneous precipitation) and the h05 and h05B products (accumulated precipitation).
Other H-SAF products are not supported at this time.
An example: H-SAF instantaneous precipitation (h03B product) for Kenya.
flake8 satpy