-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoding of mersi2 l1b reader valid_range for channel 24 and 25 as these are wrong in the HDF data #874
Hardcoding of mersi2 l1b reader valid_range for channel 24 and 25 as these are wrong in the HDF data #874
Conversation
… in the HDF data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR. I'm wondering if we should be proactive and check the version of the file format (if there is such info in the file ?) also, so that it'll be forward compatible too ?
I can't see any version information. What the PR do is that it check the current known invalid value and corrects this. When the format is updated the valid_range value is not altered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this wasn't something you needed right away, I'd say we should just wait. Since we don't know when the fix will be released I'm ok with what you have. You do have unnecessary parentheses and should have a space after the if
. Does flake8
allow this?
|
@mraspaud @TAlonglong What do we think on this? Turns out I need this and it doesn't look like a fix is coming soon (or at least there wasn't any kind of indication) as I had hoped. FYI merged with master this should pass tests again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add harcoding of mersi2 l1b reader valid_range for channel 24(10.8) and 25(12.0) as these have wrong values in the HDF data