Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LAC support to the avhrr-gac-lac reader #994

Merged
merged 5 commits into from
Dec 6, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 4, 2019

The newest release of pygac should support LAC data reading. This PR makes sure satpy does too.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud self-assigned this Dec 5, 2019
@mraspaud mraspaud marked this pull request as ready for review December 5, 2019 12:49
@coveralls
Copy link

coveralls commented Dec 5, 2019

Coverage Status

Coverage increased (+0.0008%) to 86.895% when pulling 28d5654 on mraspaud:feature-lac into 7219160 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #994 into master will increase coverage by 0.01%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   86.89%   86.91%   +0.01%     
==========================================
  Files         181      181              
  Lines       27500    27778     +278     
==========================================
+ Hits        23896    24143     +247     
- Misses       3604     3635      +31
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_avhrr_l1b_gaclac.py 98.03% <100%> (+0.04%) ⬆️
satpy/readers/avhrr_l1b_gaclac.py 94.59% <77.77%> (-0.26%) ⬇️
satpy/tests/reader_tests/test_seviri_l1b_native.py 93.51% <0%> (+0.18%) ⬆️
satpy/readers/seviri_l1b_native.py 73.87% <0%> (+6.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7219160...28d5654. Read the comment docs.

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Dec 6, 2019
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, LGMT!

@mraspaud mraspaud merged commit 3ebedbb into pytroll:master Dec 6, 2019
@mraspaud mraspaud deleted the feature-lac branch December 6, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants