Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projected grid lines to gv feature #245

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

ahuang11
Copy link
Collaborator

I was thinking of adding it to bokeh/plot.py/GeoPlot, but I didn't know how to do it without making the resulting element a GeoOverlayPlot automatically so I thought maybe just make it more accessible as a feature

image

@@ -65,6 +65,12 @@ def __init__(self, element, **params):
show_bounds = self._traverse_options(element, 'plot', ['show_bounds'],
defaults=False)
self.show_bounds = not any(not sb for sb in show_bounds['show_bounds'])
if self.show_grid:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider having show_grid add these gridlines in future.

@philippjfr
Copy link
Member

Thanks, this looks like a valuable addition. I've made one comment but we can address that in future.

@philippjfr philippjfr merged commit 45a7ea7 into holoviz:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants