-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HoloMap and default params #704
Comments
Don't like this suggestion much, seems like it's overloading the parameter and nothing about Only meaningful thing would be to add a |
I agree that adding a default parameter to Dimension would be the appropriate way to support this. Dimension is looking quite suspiciously like a param.Parameter at this point; can you remind me why it is not the same thing? |
Conceptually they are very similar but the difference is that a parameter is declared statically on a class, while you want to supply lists of custom dimensions to an instance. Maybe I'm missing something obvious but I can't quite see how that would work using a |
There are two reasons I suggested using
|
Sure, but that's not really a good reason to abuse an existing parameter in this way. Semantically it makes no sense to me, there would be no way to supply both a default value and a soft-range and any code dealing with
Personally I don't see the harm in adding parameters that make sense and provide useful functionality, and definitely prefer it to overloading an existing parameter in weird ways. Whether this particular feature is important enough to warrant the addition I'm not so sure. |
I remember having a discussion about Dimension vs. Parameter years ago; I just don't remember the content of it. Parameter itself doesn't know that it's on a Parameterized, and so I suspect the Parameter class would work fine as a Dimension. But it would make more sense for Dimension to be a superclass of Parameter, with Parameter adding the methods that take an obj argument. And I think the outcome of that discussion was that we want Dimensions to have Parameters, which of course then isn't possible. Still, it's frustrating that we have duplicated such fundamental semantically related concepts. As for adding a "default" parameter to a Dimension, that seems fine to me. |
I agree it might not be worth the extra conditional code for what would effectively be a hidden feature. Based on that, I don't think this feature warrants an additional parameter. I think keeping |
Unfortunately I think we didn't capture that discussion because it was in person as part of a CSNG meeting. I think we did agree that there is a shared high-level concept that could be moved into param, but then got a bit derailed in philosophical discussions to the point where we jokingly discussed a |
I think it should be called My own feeling is that |
I think with either Notion or Concept as a base class, we'd need to have a further base class above that, |
The issue with dimension semantics has been resolved and a 'default' parameter on dimension should be fine. It shouldn't be a big job but we want to release 1.7 right now so I've assigned this to a 1.7.1 milestone. |
Ok, thanks. Please do add this; I'm tired of having to work around the fact that all sliders start at the left, which is not always a very useful portion of the parameter space! |
Hello, I came across this conversation and am also interested. Does this mean that when this is available, the below will work?
As of 1.8dev2, the code still defaults |
@jordansamuels That's right...the slider would then start at 1. I would very much like this feature to be in 1.8 but at this point it doesn't look like that will be possible. |
@philippjfr I would love to have this ahead of Scipy! I don't know if it will be possible but I'll optimistically assign to 1.8.1 anyway. |
Definitely not happening before SciPy. Also this is a feature and should therefore wait for a non-minor release. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I would like to display a holomap or dynamic map, with the scrubber in the slider could start at a certain point in the middle of the slider and not at the beginning. What should be changed to support this feature?
jlstevens wrote:
The text was updated successfully, but these errors were encountered: