-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interpolate_curve operation and Curve interpolation plot option #1097
Conversation
@jordansamuels I've now implemented support for stepping on Curves. |
Bit perplexed by the persistent python2 test failure. Importing from import |
I think an interpolation plot option would be very reasonable but I think the implementation should be generalized further. I would like to see |
holoviews/operation/element.py
Outdated
return steps | ||
|
||
|
||
class step_curve(ElementOperation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider generalizing this to an interpolate_curve
that supports the same interpolation options as CurvePlot
- currently this would just mean adding a 'linear' option that does nothing. I would also consider making the functions above into classmethods.
617b6dd
to
15ea039
Compare
Updated, ready to merge when tests pass. |
15ea039
to
8933fa2
Compare
8933fa2
to
4f6114a
Compare
After rebasing with master this now seems to work okay, ready to merge. |
I guess we could have bezier/splice interpolation in future by sampling a spline into a Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Recently I prototyped a
Steps
Element which would plot changes in the y-values of a Curve as discrete steps. It was pointed out this really just represents different interpolation behavior forCurve
plots. I think this is a good suggestion, and I'd like to start using it for a project I'm working on. I've addedstep_curve
as a separate operation so you can also plot steps when datashading simply by applying it to the Curve before datashading is applied. Here's what it looks like: