Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed batched plot style cycles/palettes #1206

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Mar 13, 2017

Color cycles on batched plots were computed incorrectly resulting in colors to be repeated and not matching with other plots.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Mar 13, 2017

Sounds like a bug we would notice pretty quickly! Since when have color cycles been behaving badly with batch mode?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Mar 13, 2017

Since when have color cycles been behaving badly with batch mode?

Always. It would have been less noticeable if only a few items were changing each time or if there are a lot of them.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Mar 13, 2017

If you rebase against master, the tests should run properly again. Then if it is ready, I can merge.

@philippjfr philippjfr force-pushed the fixed_batched_dynamic_styles branch from e320eeb to f3bb186 Mar 13, 2017

@jlstevens jlstevens merged commit 5232d0e into master Mar 14, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 78.561%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the fixed_batched_dynamic_styles branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.