Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in sorting on array interface #1399

Merged
merged 2 commits into from
May 3, 2017
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 3, 2017

It appears that sorting on the ArrayInterface was broken in certain cases, this creates a recarray view to perform the sorting on, which should work more robustly. I'll add a couple of tests before this is ready to merge.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: component: data labels May 3, 2017
@philippjfr
Copy link
Member Author

Ready to review. Note that the grid interfaces don't support sorting in general and neither does dask, hence the "Not supported" unit tests.

@philippjfr philippjfr requested a review from jlstevens May 3, 2017 17:18
@jlstevens
Copy link
Contributor

Using a record array like that seems a bit like a big hammer but I can see why it might be more reliable. Anyway, looks good and the tests are passing. Merging.

@jlstevens jlstevens merged commit feb2a5c into master May 3, 2017
@philippjfr
Copy link
Member Author

Using a record array like that seems a bit like a big hammer but I can see why it might be more reliable.

Since it's just a view it should be fairly lightweight, and looking back at it I think it was using a record array without explicit naming before anyway. Seems to be the only way to sort by column.

@jlstevens
Copy link
Contributor

For lexical sort? Right, I've used record arrays for that before...

@philippjfr
Copy link
Member Author

For lexical sort? Right, I've used record arrays for that before...

Right.

@jbednar jbednar deleted the array_interface_sort_fix branch May 3, 2017 18:15
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: component: data type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants