Replace bkcharts based BoxWhisker with pure bokeh implementation #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests will now go green. Merge when they do? |
jlstevens
reviewed
Jun 25, 2017
| else: | ||
| return factors, [] | ||
|
|
||
| def get_data(self, element, ranges=None, empty=False): |
There was a problem hiding this comment.
This method is really long. If it can be broken up into sensible chunks, then that might help readability.
|
Looks good. I'll merge when the tests go green again. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace last bkcharts based plot implementation with bokeh plotting API based implementation. Here's the notebook containing the implementation:
https://anaconda.org/philippjfr/boxwhisker/notebook