Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bkcharts based BoxWhisker with pure bokeh implementation #1604

Merged
merged 19 commits into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jun 24, 2017

Replace last bkcharts based plot implementation with bokeh plotting API based implementation. Here's the notebook containing the implementation:

https://anaconda.org/philippjfr/boxwhisker/notebook

  • Allow separate styling of whiskers, boxes and outliers
  • Add coloring support
  • Correctly handle univariate BoxWhisker.
  • Support nice hover info
  • Support invert_axes

@philippjfr philippjfr removed the WIP label Jun 25, 2017

Philipp Rudiger added some commits Jun 25, 2017

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jun 25, 2017

Looks like the tests will now go green. Merge when they do?

else:
return factors, []

def get_data(self, element, ranges=None, empty=False):

This comment has been minimized.

@jlstevens

jlstevens Jun 25, 2017

Contributor

This method is really long. If it can be broken up into sensible chunks, then that might help readability.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jun 25, 2017

Looks good. I'll merge when the tests go green again.

@jlstevens jlstevens merged commit eaefeab into master Jun 25, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.974%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the replace_charts branch Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.