Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for changes to categorical handling in bokeh 0.12.7 #1849

Merged
merged 5 commits into from
Sep 4, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 4, 2017

Addresses #1839 by adding support for the new categorical handling to bokeh Bar plots.

Old Bars:

screen shot 2017-09-04 at 2 00 35 pm

New Bars:

screen shot 2017-09-04 at 2 14 29 pm

Old BoxWhisker:

screen shot 2017-09-04 at 2 15 04 pm

New BoxWhisker:

screen shot 2017-09-04 at 2 12 14 pm

@jlstevens
Copy link
Contributor

Looks good and the tests seem to be passing. Ready to merge?

@philippjfr
Copy link
Member Author

Just pushed one more commit which should also address #1091 going forward.

@philippjfr
Copy link
Member Author

@jlstevens Ready to merge now.

@jlstevens
Copy link
Contributor

When bokeh 1.0 comes out I hope we can get rid of all these version conditionals for all prior versions. Anyway, merging.

@jlstevens jlstevens merged commit 39a8f50 into master Sep 4, 2017
@philippjfr philippjfr deleted the bokeh_categorical_fixes branch September 28, 2017 20:11
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants