Cleaned up Element range handling #1876
Conversation
philippjfr
added
type: bug
philippjfr
force-pushed
the
quadmesh_range
branch
2 times, most recently
from
643fa8f
to
5c493a4
Compare
| """ | ||
| Computes the range along a dimension by combining the data range | ||
| with the Dimension soft_range and range. | ||
| """ |
There was a problem hiding this comment.
I would be surprised if we don't have very similar logic to this somewhere else in holoviews already...
There was a problem hiding this comment.
I see you replaced two chunks of code with this utility below, is that everywhere this utility could be used?
|
Looks good. It would be good if you could check that |
philippjfr
force-pushed
the
quadmesh_range
branch
2 times, most recently
from
35e02c3
to
6a0ab9b
Compare
philippjfr
changed the title
|
I think this was long overdue tbh, there were various inconsistencies in the implementations. |
philippjfr
force-pushed
the
quadmesh_range
branch
4 times, most recently
from
09a5fb1
to
0c76497
Compare
philippjfr
force-pushed
the
quadmesh_range
branch
from
0c76497
to
35bbc26
Compare
|
Tests are green, if you think you've used this new utility everywhere that makes sense, I'm happy to merge. |
|
Yes, that's every single range implementation now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As described in #1870, QuadMesh is currently not handling explicitly set dimension ranges. This PR adds a utility to combine the data range with the dimension ranges and uses it in various Element.range implementations.