-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored plotly backend #3256
Conversation
@jonmmease Still working on this a bit but I wanted to check with you before getting much further into this. The PR refactors the element plotting classes a bit. The main changes is that instead of declaring the |
@philippjfr, I did look over it briefly last night and this looks/sounds like a nice generalization that will be useful to support future elements. Thanks! |
e91ac7c
to
40feac8
Compare
Okay, I think I'm mostly done here. I think it is indeed a nice generalization which makes writing new plotting element plotting classes a lot easier. One thing that should be generalized further is the way styling is applied, i.e. certain style options are set on the marker while others are set on the data itself and that is not nicely handled yet. However for the time being this is already much more flexible than it was. I've also finally added unit tests for all the element plots. |
Ready to review and merge. |
wow @philippjfr, this is awesome! The plotly backend is really coming along now! Everything looks great from my end, and I'm excited to play with it soon 🙂 |
] | ||
} | ||
], | ||
"metadata": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notebook metadata needs to be stripped out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any.
I've not yet reviewed the code but I do see this PR is introducing a bunch of new notebooks. I'll be making a PR today updating all the bokeh reference gallery notebooks to use the new options style and I don't want to merge any new notebooks unless they conform to that style as well. Edit: The PR showing what has been updated for Bokeh is #3269 |
71a64f2
to
1295c38
Compare
1295c38
to
83bfe17
Compare
@philippjfr told me this is now ready to merge. Thanks for updating the notebooks as requested. Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Cleanup and refactoring of the plotly backend.
invert_axes
andinvert_x/y/zaxis
optionsxticks
/yticks
/zticks
LabelPlot
,AreaPlot
,SpreadPlot
,ViolinPlot