Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optimized TriMesh wireframe rendering #3495

Merged
merged 4 commits into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented Feb 14, 2019

Uses optimized datashader segments rendering for TriMesh wireframes and adds support for generating a wireframe using interpolation=None and aggregator='any'/'count'.

Here's the performance profiling for the initial render (which includes the time converting the trimesh to a wireframe of paths and segments):

bokeh_plot

  • Add tests
@jbednar
Copy link
Contributor

jbednar left a comment

Looks good to me. Are False and None now synonyms? It would be good to state that explicitly somewhere.

philippjfr added some commits Feb 14, 2019

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Feb 15, 2019

@kcpevey Once this is merged and there's been a dev release you'll be able to speed up wiremesh plots by changing:

datashade(trimesh.edgepaths)

to:

datashade(trimesh.edgepaths, aggregator='any', interpolation=None)
@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 15, 2019

Looks good to me! Happy to see this merged.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Feb 15, 2019

Okay, the long term plan here is that we will eventually add a Segments element and then expose that using a public TriMesh.wireframe property.

@philippjfr philippjfr merged commit fe4c8bb into master Feb 15, 2019

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
s3-reference-data-cache Test data is cached.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.