Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optimized TriMesh wireframe rendering #3495

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 14, 2019

Uses optimized datashader segments rendering for TriMesh wireframes and adds support for generating a wireframe using interpolation=None and aggregator='any'/'count'.

Here's the performance profiling for the initial render (which includes the time converting the trimesh to a wireframe of paths and segments):

bokeh_plot

  • Add tests

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Feb 14, 2019
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are False and None now synonyms? It would be good to state that explicitly somewhere.

@philippjfr
Copy link
Member Author

@kcpevey Once this is merged and there's been a dev release you'll be able to speed up wiremesh plots by changing:

datashade(trimesh.edgepaths)

to:

datashade(trimesh.edgepaths, aggregator='any', interpolation=None)

@jlstevens
Copy link
Contributor

Looks good to me! Happy to see this merged.

@philippjfr
Copy link
Member Author

Okay, the long term plan here is that we will eventually add a Segments element and then expose that using a public TriMesh.wireframe property.

@philippjfr philippjfr merged commit fe4c8bb into master Feb 15, 2019
@philippjfr philippjfr deleted the trimesh_wireframe_segments branch April 29, 2019 11:25
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants