Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh improvements #362

Merged
merged 6 commits into from Dec 16, 2015

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Dec 16, 2015

This PR will include various improvements for the bokeh backend. First of all it now has proper support for blanking out frames with the empty option, which also allows downsampling to be applied without having to process all the data first. I still want to switch the VLine and HLine implementation to use BoxAnnotations to address zorder and other issues, so the PR isn't quite ready yet.

Note that while all the changes related to changing the BokehPlot get_data method to support an empty option might seem like overkill simply to get callbacks working it's also the first step to being able to reuse plots in an Overlay, which will eventually provide a major optimization.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Dec 16, 2015

It all sounds good and I don't see any huge blocks of new code to consider. You have a much better understanding of the current limitations of our Bokeh support so I am happy to let you merge whenever you think it is ready.

For VLine and HLine, I've noticed that something you can see the ends of the lines when extents change (e.g in a DynamicMap). If there much harm ( performance issues perhaps?) extending the lines say 100x the known extents to be safe? If Bokeh does effective clipping, I don't see why we need to try to set the extents of these lines to exactly what is visible.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Dec 16, 2015

I've implemented the HLine and VLine using the new Bokeh BoxAnnotation (can replace it with LineAnnotation once bokeh 0.11 is released). This means its extents always cover the full range of the plot and will always be on top of all the other Elements. With that implemented the PR is ready for merge.

jlstevens added a commit that referenced this pull request Dec 16, 2015

@jlstevens jlstevens merged commit 0b9e977 into master Dec 16, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 70.844%
Details

@philippjfr philippjfr deleted the bokeh_improvements branch Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.