Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh improvements #362

Merged
merged 6 commits into from
Dec 16, 2015
Merged

Bokeh improvements #362

merged 6 commits into from
Dec 16, 2015

Conversation

philippjfr
Copy link
Member

This PR will include various improvements for the bokeh backend. First of all it now has proper support for blanking out frames with the empty option, which also allows downsampling to be applied without having to process all the data first. I still want to switch the VLine and HLine implementation to use BoxAnnotations to address zorder and other issues, so the PR isn't quite ready yet.

Note that while all the changes related to changing the BokehPlot get_data method to support an empty option might seem like overkill simply to get callbacks working it's also the first step to being able to reuse plots in an Overlay, which will eventually provide a major optimization.

@jlstevens
Copy link
Contributor

It all sounds good and I don't see any huge blocks of new code to consider. You have a much better understanding of the current limitations of our Bokeh support so I am happy to let you merge whenever you think it is ready.

For VLine and HLine, I've noticed that something you can see the ends of the lines when extents change (e.g in a DynamicMap). If there much harm ( performance issues perhaps?) extending the lines say 100x the known extents to be safe? If Bokeh does effective clipping, I don't see why we need to try to set the extents of these lines to exactly what is visible.

@philippjfr
Copy link
Member Author

I've implemented the HLine and VLine using the new Bokeh BoxAnnotation (can replace it with LineAnnotation once bokeh 0.11 is released). This means its extents always cover the full range of the plot and will always be on top of all the other Elements. With that implemented the PR is ready for merge.

jlstevens added a commit that referenced this pull request Dec 16, 2015
@jlstevens jlstevens merged commit 0b9e977 into master Dec 16, 2015
@philippjfr philippjfr deleted the bokeh_improvements branch December 20, 2015 16:58
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants