Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in bokeh hover tool for unsanitized dimensions #524

Merged
merged 1 commit into from Feb 28, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Feb 27, 2016

The bokeh hover tool currently breaks if a dimension contains a space or other special character, the PR adds a small method to generate the hover data correctly.

@philippjfr philippjfr added this to the 1.4.4 milestone Feb 27, 2016

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 27, 2016

Also looks like the new method removes redundancy which is always good. Happy to merge if it is ready.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Feb 28, 2016

Ready to merge whenever.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 28, 2016

Now then! :-)

jlstevens added a commit that referenced this pull request Feb 28, 2016

Merge pull request #524 from ioam/hover_fix
Fixed bug in bokeh hover tool for unsanitized dimensions

@jlstevens jlstevens merged commit e09c146 into master Feb 28, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 69.216%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the hover_fix branch Apr 1, 2016

@philippjfr philippjfr modified the milestones: Major feature request, 1.4.4, v1.5.0 Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.