Added interface class for iris Cube datasets #624
Conversation
philippjfr
added
in progress
type: feature
| @@ -15,13 +15,23 @@ | |||
| from .grid import GridInterface | |||
| from .ndelement import NdElementInterface | |||
|
|
|||
| datatypes = ['array', 'dictionary', 'grid', 'ndelement'] | |||
|
|
|||
There was a problem hiding this comment.
Is this because you are considering setting datatypes with hv.core.data.datatypes = [ 'dictionary'] for example? Makes sense, for convenience but I would like to know if there was any another reason for moving it off the class itself.
There was a problem hiding this comment.
So I can populate it depending on the availability of the various data backends. Happy to change the way this is handled though.
There was a problem hiding this comment.
No, this is perfectly fine - just seems more flexible this way.
philippjfr
force-pushed
the
iris_interface
branch
2 times, most recently
from
8293694
to
84cb085
Compare
| from holoviews.element.comparison import ComparisonTestCase | ||
|
|
||
| class TestCube(ComparisonTestCase): | ||
|
|
There was a problem hiding this comment.
Great! Maybe we can get some people who are familiar with Iris tests to add some more of their own. :-)
|
Looks good! Happy to merge once the tests pass and you are happy with the number of tests for the time being. |
philippjfr
force-pushed
the
iris_interface
branch
4 times, most recently
from
70f693f
to
7586589
Compare
philippjfr
force-pushed
the
iris_interface
branch
from
7586589
to
5806223
Compare
|
Ready to merge, I think the push build is getting confused about the updated data, but the PR build passed. |
|
The pr build is the one that counts. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds an interface for iris Cube datasets to work with large out-of-memory datasets. The interface isn't entirely complete but supports all the basic functionality to work with such a dataset.
In future we can think about also implementing the
sampleandaggregatemethods but it should not hold up this PR.