Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interface class for iris Cube datasets #624

Merged
merged 4 commits into from Apr 20, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Apr 20, 2016

This PR adds an interface for iris Cube datasets to work with large out-of-memory datasets. The interface isn't entirely complete but supports all the basic functionality to work with such a dataset.

In future we can think about also implementing the sample and aggregate methods but it should not hold up this PR.

@philippjfr philippjfr added this to the v1.5.0 milestone Apr 20, 2016

@@ -15,13 +15,23 @@
from .grid import GridInterface
from .ndelement import NdElementInterface

datatypes = ['array', 'dictionary', 'grid', 'ndelement']

This comment has been minimized.

@jlstevens

jlstevens Apr 20, 2016

Contributor

Is this because you are considering setting datatypes with hv.core.data.datatypes = [ 'dictionary'] for example? Makes sense, for convenience but I would like to know if there was any another reason for moving it off the class itself.

This comment has been minimized.

@philippjfr

philippjfr Apr 20, 2016

Author Contributor

So I can populate it depending on the availability of the various data backends. Happy to change the way this is handled though.

This comment has been minimized.

@jlstevens

jlstevens Apr 20, 2016

Contributor

No, this is perfectly fine - just seems more flexible this way.

@philippjfr philippjfr force-pushed the iris_interface branch 2 times, most recently from 8293694 to 84cb085 Apr 20, 2016

from holoviews.element.comparison import ComparisonTestCase

class TestCube(ComparisonTestCase):

This comment has been minimized.

@jlstevens

jlstevens Apr 20, 2016

Contributor

Great! Maybe we can get some people who are familiar with Iris tests to add some more of their own. :-)

from iris.util import guess_coord_axis
from holoviews.core.dimension import Dimension


This comment has been minimized.

@jlstevens

jlstevens Apr 20, 2016

Contributor

The three functions below are fine. I just hope we don't accumulate too many functions floating outside the class itself.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Apr 20, 2016

Looks good! Happy to merge once the tests pass and you are happy with the number of tests for the time being.

@philippjfr philippjfr force-pushed the iris_interface branch 4 times, most recently from 70f693f to 7586589 Apr 20, 2016

@philippjfr philippjfr force-pushed the iris_interface branch from 7586589 to 5806223 Apr 20, 2016

Philipp Rudiger added some commits Apr 20, 2016

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Apr 20, 2016

Ready to merge, I think the push build is getting confused about the updated data, but the PR build passed.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Apr 20, 2016

The pr build is the one that counts. Merging.

@jlstevens jlstevens merged commit 99bb3ad into master Apr 20, 2016

2 of 4 checks passed

s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 69.836%
Details

@philippjfr philippjfr deleted the iris_interface branch Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.