Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tutorial section to explain DynamicMap groupby methods #667

Merged
merged 1 commit into from
May 11, 2016

Conversation

philippjfr
Copy link
Member

No description provided.

@jlstevens
Copy link
Contributor

Great! Thanks for updating the docs!

Ready to merge?

@philippjfr
Copy link
Member Author

Ready.

@jlstevens jlstevens merged commit 79924b8 into master May 11, 2016
{
"cell_type": "markdown",
"metadata": {},
"source": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 714 below says "need to check" -- what's the answer to that question?

Copy link
Member Author

@philippjfr philippjfr May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, looks like @jlstevens forgot to address his own question 😄 I think the statement is correct as is, as long as the dimension is unbounded on either end it will default to open mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll remove the qualifier while I'm doing an editing pass on this tutorial to clean up the new changes.

Copy link
Contributor

@jlstevens jlstevens May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we can remove that stray comment...oops!

Edit: Thanks Jim for cleaning it up and giving it another pass!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "At least one of the declared key dimensions must have an unbounded range (i.e., with no upper bound specified)." be correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so...though Philipp suggests it works if either bounds is None, including the lower bound? I just wonder how the scrubber handles that...does it decrease starting from the upper bound?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just ignores all the bounds, at present; all that matters is that one bound is not specified. I've clarified it to say that, but we're still deciding on the larger issue of how to describe these various modes.

@philippjfr philippjfr deleted the dynamic_groupby_tutorial branch May 11, 2016 14:53
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants