Fixed handling of constant dimensions in xarray #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
in progress
type: bug
|
Looks ok, but I think we need to have a proper plan regarding constant dimensions across HoloViews. Not sure when we'll find the appropriate time to address that though... Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes handling of constant dimensions in the xarray interface of HoloViews. By default a select operation does not reduce the dimensionality of a HoloViews object, i.e. the dimensionality stays unchanged. Until we have proper support for constant dimensions this is probably the right approach, however xarray does convert coordinates to constant coordinates, which changes the shape of the array. This PR ensures that the shape of the arrays stays unchanged.