DynamicMap with streams force callback on first lookup after refresh #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -672,7 +673,8 @@ def __getitem__(self, key): | |||
|
|
|||
| # Cache lookup | |||
| try: | |||
| if util.dimensionless_contents(self.streams, self.kdims): | |||
| if (util.dimensionless_contents(self.streams, self.kdims) and | |||
| not self._stream_cache_lookup): | |||
| raise KeyError('Using dimensionless streams disables DynamicMap cache') | |||
There was a problem hiding this comment.
From our discussion, we think it ought to be something like:
if (util.dimensionless_contents(self.streams, self.kdims)
raise KeyError('Using dimensionless streams disables DynamicMap cache')
elif self._disable_cache_lookup:
raise KeyError('Cache lookup disabled')
That way the variable isn't about streams and you can disable cache lookup on dynamic maps not matter how they are (or aren't) using streams.
There was a problem hiding this comment.
I think we decided in the end that it is about streams.
|
All looks good now! Happy to merge once the tests pass. |
|
Tests are passing. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plotting code will request a particular key from a single DynamicMap multiple times during plotting which should be avoided due to potentially random state.