-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Audio message recorder and player functionality implemented #615
Conversation
Hi @sukhman-sukh , thanks for the PR! There are still some tasks that I need to take care of prior merging, but your help in getting the ball rolling and jump-starting the feature's foundation is much appreciated. A few things done so far:
I was able to test sending an audio message from a MacOS host, which worked. Still pending:
Pending definition:@MathJud do we want Linux support? As per the record package documentation, it relies on fmedia being installed separately. If we opt to add Linux support, we must also add that dependency to the snap package. |
Hey @brenodt, This is a screenshot of the android qaul application until commit #478a8e2. |
I will have a look on how to extend this to Windows, Linux, and IOS hosts. |
AndroidI tested the feature on Android 11 & 12, and it worked fine for me. |
WindowsI tested the feature on windows, and it was not active.
|
Oh! |
Hi @sukhman-sukh , I was able to verify that it works on iOS, so we're clear on that front! As it stands, there are two pending tasks here:
As soon as we're able to confirm those, this will be eligible for merging. |
Hey @brenodt, Should we create this as a separate issue and fix it or continue in this one only? Thanks. |
Hi @sukhman-sukh , from what I recall, the reason In any case, I don't think this would affect the scope of this PR, since both packages we added as deps to enable this feature support Windows: You just need to enable the audio button on Windows ( |
Yes, I see that and I am testing it on Windows . The error I described above is not about sending. It is even when I receive any attachment/audio/image in qaul. Currently, I am working on the issue and I hope, I will finish debugging it ASAP. |
Oh, I see. Cool, let me know if you need any help! |
Great! Glad to hear it, @sukhman-sukh . Are you able to take a look to confirm it's working on Linux, also? |
Hi @brenodt, Also, enabling audio-chat feature for linux as well. |
Signed-off-by: sukhman-sukh <sukhmansinghsaluja@gmail.com>
Signed-off-by: sukhman-sukh <sukhmansinghsaluja@gmail.com>
Signed-off-by: sukhman-sukh <sukhmansinghsaluja@gmail.com>
@sukhman-sukh thanks a lot for your work! |
- `Visual Studio 2022` is now required due to the required CMAKE version. - the flutter build path to copy `libqaul.dll` was corrected
As this branch had merge conflicts I rebased it to the current main branch and force pushed it here again. |
The windows build now needs |
Hi @MathJud , the version setup in CI is Visual Studio 2022, as we use the machine executor
Sources: |
The UI tooltip on the microphone recording icon show the string |
Hey @MathJud, |
The development of this PR continues in the new PR #628 628 |
Added voice chat feature.
Now, anyone can record a message from qaul application from the custom input area and send a voice message using libqual_worker and play the voice message directly from the application.
Issue Resolved :- Record and Send Voice Messages . fix #548