Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English.nsi #13615

Closed
wants to merge 1 commit into from
Closed

Update English.nsi #13615

wants to merge 1 commit into from

Conversation

bovirus
Copy link
Contributor

@bovirus bovirus commented Oct 22, 2020

Proposal for master English language change.

  • Add CR/LF for multi-period long strings.
    Each period is on separate line.
    Better clearance.

  • Remove "." for Launch qbt string.
    Not need because it's an option (not description) and typically not required "."

  • Replace "application" with "qBittorrent" (application name).
    More clear and direct.

Thanks. KR;

Proposal for master English language change.

- Add CR/LF for multi-period long strings.
Each period is on separate line.
Better clearance.

- Remove "." for Launch qbt string. 
Not need because it's an option (not description) and typically not required "."

- Replace "application" with "qBittorrent" (application name).
More clear and direct.

Thanks. KR;
@glassez
Copy link
Member

glassez commented Oct 22, 2020

  • Replace "application" with "qBittorrent" (application name).
    More clear and direct.

I wonder if the fact that the use of the term Application in the installer of "qBittorrent application" refers to "qBittorrent application" is unclear to someone?

@FranciscoPombal FranciscoPombal added NSIS NSIS installer related Translations Related to i18n or Transifex labels Oct 22, 2020
@FranciscoPombal
Copy link
Member

@glassez

I wonder if the fact that the use of the term Application in the installer of "qBittorrent application" refers to "qBittorrent application" is unclear to someone?

Never underestimate the potential of stupidity. Have you not seen some of the issues that get posted to this issue tracker on a disturbingly regular basis? This makes it a tiny bit clearer what's happening, so, on those grounds, I'm not against this change.

@bovirus
Copy link
Contributor Author

bovirus commented Oct 23, 2020

@glassez

I consider only by clear point of messages.

What's the negative point to replace "application" (generic) with "qBittorrent" (more specific)?
Same space used. More clear and direct.
And avoid misunderstanmding.

@alessandrosimonelli
Copy link
Contributor

As I suggested in #13607, regarding inst_warning and uninst_warning, "qBittorrent is running. Please close qBittorrent it before (un)installing." is still clear but has the benefit of avoiding repetition.

@bovirus
Copy link
Contributor Author

bovirus commented Oct 26, 2020

@alessandrosimonelli

It's your persoinal opinion.

For me is not a ripetition.
It's a specific explanation that is not relative to "application" (genric) but about specfici "qBittorrent".

As explained also by @FranciscoPombal to avoid any type of misunderstanging it's better to avoid to consider "clear" generic term and use instead as much as possible direct and clear term.

@RockyTDR
Copy link
Contributor

@glassez @FranciscoPombal @bovirus

About changing "application" to "qBittorrent": I did the same for the Dutch translations in this pull request: #13609
I received criticism the same way bovirus did. This was my answer: "computer novices (like my mom) don't exactly understand what "the application" refers to. They could (and my mom did) think that it refers to the installer application they just downloaded and opened. Ideally, the English source string would have been edited to prevent any confusion."

@alessandrosimonelli I also like the solution to replace "the application" by "it" to prevent repetition. Either way, I think it's a good idea to change the strings to prevent confusion.

@RockyTDR RockyTDR mentioned this pull request Nov 16, 2020
@glassez
Copy link
Member

glassez commented Nov 17, 2020

About changing "application" to "qBittorrent": I did the same for the Dutch translations in this pull request: #13609
I received criticism the same way bovirus did. This was my answer: "computer novices (like my mom) don't exactly understand what "the application" refers to. They could (and my mom did) think that it refers to the installer application they just downloaded and opened. Ideally, the English source string would have been edited to prevent any confusion."

Well, that makes sense.
I suggest the following rule:

  1. Use the word qBittorrent when it is mentioned for the first time within a string.
  2. If the string contains other references to qBittorrent, then use it (rather than repeating qBittorrent).

What do you say?

@RockyTDR RockyTDR mentioned this pull request Nov 17, 2020
sledgehammer999 pushed a commit that referenced this pull request Nov 25, 2020
As referenced in #13615
and suggested by @glassez 
- Use the word qBittorrent when it is mentioned for the first time within a string.
- If the string contains other references to qBittorrent, then use it (rather than repeating qBittorrent).

Line 24 is the updated Dutch translation for the recently updated English source string (may 2020)
sledgehammer999 pushed a commit that referenced this pull request Dec 27, 2020
Merged my previous fixes (discussed in #13607) with the suggestions by @glassez (#13615).
@github-actions
Copy link

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

@github-actions github-actions bot added the Stale label Aug 11, 2021
@github-actions
Copy link

This PR was closed because it has been stalled for some time with no activity.

@github-actions github-actions bot closed this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSIS NSIS installer related Stale Translations Related to i18n or Transifex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants