Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index torrents table by queue position #18623

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

glassez
Copy link
Member

@glassez glassez commented Feb 26, 2023

This should prevent SQLite temporary files from being created for transient index when selecting torrents ordered by queue position.

@glassez glassez added the Core label Feb 26, 2023
@glassez glassez added this to the 4.6.0 milestone Feb 26, 2023
@glassez glassez requested a review from a team February 26, 2023 09:14
Copy link
Contributor

@thalieht thalieht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything, i can't see the file from #18571 either way.

@glassez
Copy link
Member Author

glassez commented Feb 26, 2023

i can't see the file from #18571 either way.

Me too. But it looks like the database should be big enough for you to notice it.

@glassez glassez merged commit c51aa2d into qbittorrent:master Feb 28, 2023
@glassez glassez deleted the sqlite-index branch February 28, 2023 05:57
@glassez
Copy link
Member Author

glassez commented Feb 28, 2023

It can also speed up the startup process a bit by avoiding the creation of transient indexes and thus temporary files. Although it is unlikely that it can be noticed, unless you have a lot of torrents.

@thalieht
Copy link
Contributor

thalieht commented Mar 1, 2023

I didn't get this when i was testing. Now i get:

Application failed to start.

index torrents_queue_position_INDEX already exists Unable to execute statement

/Off topic
I can no longer compile with qt6+qmake since #18528

@glassez
Copy link
Member Author

glassez commented Mar 1, 2023

I didn't get this when i was testing. Now i get:

Application failed to start.

index torrents_queue_position_INDEX already exists Unable to execute statement

Good catch 👍
#18638 should prevent such a problem in the future but currently corrupted database needs to be recovered manually (you need to manually set meta.version to 4).

@glassez
Copy link
Member Author

glassez commented Mar 1, 2023

/Off topic
I can no longer compile with qt6+qmake since #18528

Strange, I don't have such a problem with Qt 6.4.2 MSVC.

@glassez
Copy link
Member Author

glassez commented Mar 1, 2023

/Off topic
I can no longer compile with qt6+qmake since #18528

Strange, I don't have such a problem with Qt 6.4.2 MSVC.

Also no problem on Linux CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants