Provide context field to translation strings

[Chocobo1]

No description provided.

[glassez]

Note that many of translations affected by this patch are never actually used (since they are used before translator is initialized). So maybe drop these strings from being translated at all?

[Chocobo1]

Note that many of translations affected by this patch are never actually used (since they are used before translator is initialized). So maybe drop these strings from being translated at all?

If my reading is correct, cmdoptions.cpp and upgrade.cpp is affected. Or move the translator initialization earlier? (before upgrade.cpp)

[Chocobo1]

So maybe drop these strings from being translated at all?

Wouldn't this become a review/maintenance burden? Maybe in the future, you and contributors will forgot and still add tr() then?

[thalieht]

Note that many of translations affected by this patch are never actually used (since they are used before translator is initialized). So maybe drop these strings from being translated at all?

If my reading is correct, cmdoptions.cpp and upgrade.cpp is affected.

Maybe i didn't understand what you guys are talking about but i tested before this patch qbittorrent --help and .e.g. "Display program version and exit" is translated, all of them actually (tested with Deutch).

[Chocobo1]

Maybe i didn't understand what you guys are talking about but i tested before this patch qbittorrent --help and .e.g. "Display program version and exit" is translated, all of them actually (tested with Deutch).

I verified it on Windows. It seems Qt defaults to OS locale settings and qbt overwrites it later. So dropping translation strings is not a good idea.

[glassez]

It seems Qt defaults to OS locale settings and qbt overwrites it later.

It is just processed after translation is initialized.
On closer inspection there are quite a few strings that are processed before translation is initialized.