Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA CI: don't use hardcoded path #20763

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

Chocobo1
Copy link
Member

No description provided.

@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Apr 27, 2024
@Chocobo1
Copy link
Member Author

Chocobo1 commented Apr 27, 2024

Note that the recent CI failure on macOS is unrelated to this change. In short the homebrew made a mistake when packaging openssl 3.3.0 and they fixed it afterwards. The macOS image cached the faulty openssl 3.3.0 package before the fix was released and now we are stuck with it. AFAIK macOS image will be updated weekly so the issue will resolve itself eventually (when macOS image updates to the latest openssl package).

@glassez
Copy link
Member

glassez commented Apr 27, 2024

the issue will resolve itself eventually (when macOS image updates to the latest openssl package).

Shouldn't we wait for that before we merge this PR?

@Chocobo1
Copy link
Member Author

Chocobo1 commented Apr 27, 2024

Shouldn't we wait for that before we merge this PR?

OK I'll trigger rebuild of macOS CI jobs when the new image is released. And merge this when it build successfully.

@xavier2k6
Copy link
Member

xavier2k6 commented Apr 27, 2024

macos-14/macos-latest labels now default to using arm runner images, 12/13 are still intel based.

@Chocobo1
Copy link
Member Author

the issue will resolve itself eventually (when macOS image updates to the latest openssl package).

Shouldn't we wait for that before we merge this PR?

Someone reported it: actions/runner-images#9755

@xavier2k6
Copy link
Member

Is there a reason we keep this at 17? master has changed to 20

-DCMAKE_CXX_STANDARD=17 \

New C++ projects you create in Xcode use C++20 language dialect by default

macos-14/macos-latest uses Xcode 15.0.1 (default)

@Chocobo1
Copy link
Member Author

Is there a reason we keep this at 17? master has changed to 20

I did attempt to change it but it resulted in build errors. I already submitted patches to libtorrent (and merged) but that branch hasn't seen a new release.

@xavier2k6
Copy link
Member

New macOS image deployed with openssl/homebrew package fix, re-ran CI on all 4x macOS builds which have passed.

@Chocobo1 Chocobo1 merged commit 04154eb into qbittorrent:master May 16, 2024
13 of 14 checks passed
@Chocobo1 Chocobo1 deleted the homebrew branch May 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants