set ports instead of network_mode #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Nice catch. Thanks for creating the PR. Can you please check other engines as well and update the PR if required? :) |
@KShivendu i just went through them and weaviate also needed an update. just pushed and its working for me now. |
|
I really need this too! |
|
Can you look on it again @KShivendu ? |
Merged. Thanks for asking. Ps. You can always checkout the branch and run it anyways :) thanks for contributing @ekorman |
KShivendu
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the docker compose files which use
network_mode: hostcurrently do not work on systems such as macos where docker uses a VM, causingrun.pyto error. this PR explicitly sets the ports