Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure tool copy settings update #8721

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

selmaVH1
Copy link
Collaborator

fixes #8450

@DelazJ DelazJ added backport release_3.34 On merge create a backported pull request to 3.34 Project/Configuration project properties, global options and settings labels Dec 22, 2023
@@ -1048,8 +1048,20 @@ Keep in mind that the first row will contain only coordinates, as it represents
Now it is possible to copy all your line measurements at once to the clipboard
using the :guilabel:`Copy` button. Clicking the :guilabel:`Configuration` button
you will access to :guilabel:`Measure Tool Copy Settings` where you can set up copy options.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
you will access to :guilabel:`Measure Tool Copy Settings` where you can set up copy options.
you will access to :guilabel:`Measure Tool Copy Settings` where you can set up :ref:`copy options <measure_copy_settings>.

adding some sort of link to the section

@@ -1048,8 +1048,20 @@ Keep in mind that the first row will contain only coordinates, as it represents
Now it is possible to copy all your line measurements at once to the clipboard
using the :guilabel:`Copy` button. Clicking the :guilabel:`Configuration` button
you will access to :guilabel:`Measure Tool Copy Settings` where you can set up copy options.
When you have the :guilabel:`Always use decimal point` option checked, the
coordinates copied to the clipboard will use a dot as the decimal separator.
This happens even if your computer's language settings normally use a comma for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it about the computer's language or the one you select in QGIS Options?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I changed it from "computer's language" to "QGIS language settings"...

Comment on lines 1051 to 1064
When you have the :guilabel:`Always use decimal point` option checked, the
coordinates copied to the clipboard will use a dot as the decimal separator.
This happens even if your computer's language settings normally use a comma for
decimals. In this case if you don't have the :guilabel:`Always use decimal point`
option checked you will be unable to select comma as a field separator.
To stop measuring, click the right mouse button.

.. _figure_measure_tool_copy_settings:

.. figure:: img/measure_copy_settings.png
:align: center

Measure Tool Copy Settings

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the description and screenshot in the Options --> map tools section.
And I wonder if we should explain the copy options here, or consider that what can be done in the "measure tool copy options" dialog should be explained in its own section, in the options/map tools page? We could just add a link to that specific section (see other comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a reference in the map_view, and I updated the 'measure tool copy options' in accordance with issue #8450.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this new image if options_map_tools.png is updated? It contains that widget already.

@DelazJ DelazJ merged commit 6edb502 into qgis:master Dec 28, 2023
3 checks passed
DelazJ added a commit that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3.34 On merge create a backported pull request to 3.34 Project/Configuration project properties, global options and settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measure Tool - Disable comma field separator when it is used as decimal separator (Request in QGIS)
2 participants