Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to allow compilation under ubuntu wily #2587

Closed
wants to merge 165 commits into from
Closed

Workaround to allow compilation under ubuntu wily #2587

wants to merge 165 commits into from

Conversation

luipir
Copy link
Contributor

@luipir luipir commented Dec 16, 2015

continuing having strange errors compiling tests under Ubuntu 15.10 (wily)

just renaming some tests (as done my Nyall in 57c22e5) solve the problem

@mbernasocchi
Copy link
Member

fixes the issue :)

@mbernasocchi
Copy link
Member

this procedure also works for me:

  • build -> error
  • apply PR
  • build -> no error
  • revert PR
  • build -> no error

@jef-n
Copy link
Member

jef-n commented Dec 16, 2015

@mbernasocchi looks like a perfect fix then ;)

@mbernasocchi
Copy link
Member

Yep... A magic fix :)

@m-kuhn
Copy link
Member

m-kuhn commented Dec 18, 2015

Is this PR required or not?
I don't see any problem with merging it if it makes ubuntu dev's lifes easier but I'm not a Ubuntu user.

If it helps, please merge, if not, please close, thanks :)

@luipir
Copy link
Contributor Author

luipir commented Dec 18, 2015

who is the target of your comment @m-kuhn ?

@jef-n
Copy link
Member

jef-n commented Dec 18, 2015

Did any wily user file a ticket against ubuntu yet? I think this should be fixed in wily/amd64 and not here - because it cannot because QGIS isn't broken.

@m-kuhn
Copy link
Member

m-kuhn commented Dec 18, 2015

@luipir the wily user which @jef-n targetted ;)

Concerning order of action I'd say:

  • "Wily user" opens a bug upstream
  • "Wily user" links it in here
  • Merge this and similar fixes until upstream fixed their issues

@luipir
Copy link
Contributor Author

luipir commented Dec 18, 2015

doing it

@luipir
Copy link
Contributor Author

luipir commented Dec 18, 2015

opened...
https://bugs.launchpad.net/ubuntu/+bug/1527722
but really don't know what component is responsible of the issue. Please add comments in this issue and in the above.

@luipir
Copy link
Contributor Author

luipir commented Dec 18, 2015

done
https://bugs.launchpad.net/ubuntu/+bug/1527722
But it's a really generic bug report... if someone have more info to add, please add to the above tiket (and here)

@luipir luipir closed this Dec 18, 2015
@luipir luipir reopened this Dec 18, 2015
@m-kuhn
Copy link
Member

m-kuhn commented Dec 19, 2015

I don't have the means to debug this problem. But it would be good to state if the .moc files in question are not being generated. I think it is a cmake automoc problem, but not sure exactly.

@luipir
Copy link
Contributor Author

luipir commented Dec 19, 2015

times ago I did a test if the problem was related to parallel make... but the issue remains also using a single core.

I really don't understand what would be the relation with the change of the test name

@m-kuhn
Copy link
Member

m-kuhn commented Dec 19, 2015

I could imagine that the cmake system somehow thinks that the .moc file has already been generated although it isn't (due to some caching or timestamps) and by changing the name you make it treat the file as new hence regenerating the .moc dependency.

But I would expect an issue like this to surface locally on isolated systems and not in parallel on several ones, so that's where it becomes dubious for me.

@m-kuhn
Copy link
Member

m-kuhn commented Dec 21, 2015

As it has gotten quiet around here, I guess this can be closed?

@luipir
Copy link
Contributor Author

luipir commented Dec 21, 2015

we are discussing here: https://bugs.launchpad.net/ubuntu/+source/qgis/+bug/1527722

@m-kuhn
Copy link
Member

m-kuhn commented Dec 21, 2015

I guess the discussion there can take a longer time, so I would prefer to decide if we merge such workarounds meanwhile on our side or close this PR and wait for the fix.

@m-kuhn
Copy link
Member

m-kuhn commented Dec 23, 2015

I just had the same issue with Ubuntu 12.04 and cmake 3.1.2 binaries. Same tests, I wonder what's special about them.

wonder-sk and others added 23 commits January 6, 2016 16:11
Now all classes and members are either exposed to bindings or marked
as "not available in Python bindings" in the docs.

Drop test thresholds to 0. Now it should be much easier to determine
what missing members have been added which are causing test
failures.
- North arrow, scalebar, and copyright label updated to include a
  margin option on placement.
- All qgsdecorationitem type dialogs amended so that all widgets sit
  within a checkable group box for activating/deactivating the item.
A new control for setting a label's "z-index" has been added to
the labeling properties dialog. This control (which also accepts
data-defined overrides for individual features) determines the order
in which label are rendered. Label layers with a higher z-index
are rendered on top of labels from a layer with lower z-index.

Additionally, the logic has been tweaks so that if 2 labels have
matching z-indexes, then:
- if they are from the same layer, a smaller label will be drawn
above a larger label
- if they are from different layers, the labels will be drawn in
the same order as the layers themselves (ie respecting the order
set in the legend)

Diagrams can also have their z-index set (but not data defined)
so that the order of labels and diagrams can be controlled.

Note that this does *NOT* allow labels to be drawn below the
features from other layers, it just controls the order in which
labels are drawn on top of all the layer's features.

Fix #13888, #13559
Allows easy duplication of a symbol layer
@luipir
Copy link
Contributor Author

luipir commented Jan 15, 2016

I close and reopen better rebased from a branch

@luipir
Copy link
Contributor Author

luipir commented Jan 15, 2016

reopened with clean rebase as #2679

@LocutusOfBorg
Copy link
Contributor

can anybody pretty please try cmake 3.5.1 from xenial that I have just uploaded?
thanks

@luipir
Copy link
Contributor Author

luipir commented Mar 30, 2016

@LocutusOfBorg plese add you comments in #2679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.