Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "snapping mode" option #3222

Merged
merged 1 commit into from
Jun 23, 2016
Merged

rename "snapping mode" option #3222

merged 1 commit into from
Jun 23, 2016

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Jun 20, 2016

Fix #14828
When comes the time to document the Snapping Options dialog, it's quite difficult to find the right words; "Snapping mode" is used as well as for:

  • the to-snap-to layer selection mode : Current layer, All layers, Advanced
  • and the way to snap to that layer: To vertex, To segment, To vertex and segment, Off as described in the Digitizing tab of Settings --> Options menu.

@m-kuhn
Copy link
Member

m-kuhn commented Jun 21, 2016

Are there other places left where this needs to be adjusted? What's the proper terminology now?

  • Snapping layer selection
  • Geometry snap mode

Anything better?

@DelazJ
Copy link
Contributor Author

DelazJ commented Jun 21, 2016

Not sure there's a need elsewhere.
Not fan of "Geometry Snap Mode". This combobox is really about layer that will be snapped to, so imo should mention layer

@m-kuhn
Copy link
Member

m-kuhn commented Jun 22, 2016

Not fan of "Geometry Snap Mode". This combobox is really about layer that will be snapped to, so imo should mention layer

So what would be the proper label for the option snap to Vertex/Segment/Vertex an Segment(/Face)?

@DelazJ
Copy link
Contributor Author

DelazJ commented Jun 22, 2016

I'd say, let's use:

  • "Default snap(ping?) mode" in Settings --> Options -->Digitizing tab
  • in Settings --> Snappping Options dialog:
    • "Snapping layer selection" for the first combobox with current layer, all visible layers and Advanced
    • "Snap(ping?) mode" for the combobox with to vertex, to segment ...
    • "Snap(ping?) mode" for the field showing to vertex, to segment ... when Advanced layer selection is active (instead of just "Mode") - for consistency

@DelazJ
Copy link
Contributor Author

DelazJ commented Jun 22, 2016

@m-kuhn

Are there other places left where this needs to be adjusted? What's the proper terminology now?

  • Snapping layer selection
  • Geometry snap mode

Anything better?

Actually, these labels were for the two options, right? Sorry, I misunderstood and thought it was 2 proposals for the first combobox.
Ok for the first, no strong opinion for the second (use of geometry)

@m-kuhn
Copy link
Member

m-kuhn commented Jun 22, 2016

Yes, I just searched for two terms that are concise and clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants