Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Processing raster calc: add missing btns and validate #32890

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Nov 15, 2019

Add missing buttons for ABS/MIN/MAX and validate expression.

processing-raster-calc-validator

@elpaso elpaso added Feature GUI/UX Related to QGIS application GUI or User Experience Processing Relating to QGIS Processing framework or individual Processing algorithms labels Nov 15, 2019
@roya0045
Copy link
Contributor

Do the 3 functions comes with parenthesis by default or does the user need to specify? Also auto englobing (select "str", hit 'Max', "str" -> Max("str") ), I'm not sure what it's called.

@elpaso
Copy link
Contributor Author

elpaso commented Nov 15, 2019

@roya0045 there is nothing really new here, these buttons are already available since 3.10 in the main menu -> Raster -> Raster Calculator C++ implementation, I just ported them to the Python side and added the validation (which is also already available in the C++ raster calculator dialog).

I f you are looking for a pet project, refactoring a bit the C++ implementation in a way that we don't have to duplicate things in the Python side could be a nice one :)

@roya0045
Copy link
Contributor

@roya0045 there is nothing really new here, these buttons are already available since 3.10 in the main menu -> Raster -> Raster Calculator C++ implementation, I just ported them to the Python side and added the validation (which is also already available in the C++ raster calculator dialog).

Yeah I saw the code afterward.

I f you are looking for a pet project, refactoring a bit the C++ implementation in a way that we don't have to duplicate things in the Python side could be a nice one :)

I don't think this endeavor would benefit my employer/myself, my PRs do but the delays are unpleasant.

@elpaso elpaso merged commit 29824c1 into qgis:master Nov 16, 2019
@elpaso elpaso deleted the processing-raster-calc-expression-check branch November 16, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature GUI/UX Related to QGIS application GUI or User Experience Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants