Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] allow to drag'n'drop layer across several QGIS instances #35382

Merged
merged 5 commits into from
May 6, 2020
Merged

[FEATURE] allow to drag'n'drop layer across several QGIS instances #35382

merged 5 commits into from
May 6, 2020

Conversation

3nids
Copy link
Member

@3nids 3nids commented Mar 26, 2020 •
edited
Loading

fixes #20467

a screencast is worth a few words
ezgif-6-edfa78f0a50a

sponsored by the QGIS Swiss user group

@3nids 3nids mentioned this pull request Mar 26, 2020
Closed
@github-actions github-actions bot added this to the 3.14.0 milestone Mar 26, 2020
@3nids 3nids added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Mar 26, 2020
@qgis-bot

This comment has been minimized.

Sign in to view
@nyalldawson
Copy link
Collaborator

Nice feature!

Would it be possible to add a message bar warning if a memory layer is dropped between windows?

@3nids
Copy link
Member Author

3nids commented Mar 27, 2020

Would it be possible to add a message bar warning if a memory layer is dropped between windows?

by creating signals from core/layer-tree to be received in app ?

@nyalldawson
Copy link
Collaborator

by creating signals from core/layer-tree to be received in app ?

Hm, i guess... yeah

@stale
Copy link

stale bot commented Apr 10, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 10, 2020
@stale
Copy link

stale bot commented Apr 17, 2020

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Apr 17, 2020
@3nids 3nids mentioned this pull request Apr 22, 2020
Closed
@bru500
Copy link

bru500 commented Apr 29, 2020

Very nice feature!
@3nids. I'd appreciate this feature a lot, working all days with many qgz and mooving layers to and fro. Do you have plans to merge?
For the record: I just opened a bug report for adding a layer from an other qgz by the browser #36088. Please note, that drag & drop of whole groups of layers from an other qgz via browser would be very useful and is closely related to this pull request.

@3nids 3nids reopened this May 1, 2020
@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 1, 2020
@3nids 3nids force-pushed the dnd-across-qgis-instances branch from 87a1acf to 01f7662 Compare May 5, 2020 07:25
@3nids 3nids requested a review from nyalldawson May 5, 2020 07:26
@3nids
Copy link
Member Author

3nids commented May 5, 2020

@nyalldawson I added the message.
Sadly, we cannot give any feedback (easily) on the numbers of added layers (they are not added to the legend in addMapLayers), but I don't think it's an issue.
Good for you?

3nids
3nids commented May 5, 2020
View reviewed changes
src/app/qgisapp.cpp Outdated Show resolved Hide resolved
@3nids 3nids merged commit 37efb4d into qgis:master May 6, 2020
@3nids
Copy link
Member Author

3nids commented May 6, 2020

unrelated failure

@qgis-bot qgis-bot mentioned this pull request May 6, 2020
Closed
@qgis-bot
Copy link
Collaborator

qgis-bot commented May 6, 2020

@3nids
A documentation ticket has been opened at qgis/QGIS-Documentation#5418
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@nyalldawson
Copy link
Collaborator

@3nids since this merge I get the "layers have been added" notice whenever rearrange layers in the layer tree panel

@timlinux timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Milestone
3.14 (Feature)
Development

Successfully merging this pull request may close these issues.

Drag and Drop a layer from one QGIS instance to an other
5 participants
@3nids @qgis-bot @nyalldawson @bru500 @timlinux