Tests and fix to read sld:Rotation when does not have ogc sub tags #4049
Conversation
| test_qgssymbollayer_readsld.py | ||
| ======= | ||
| test_qgssymbollayerv2_readsld.py | ||
| >>>>>>> Tests and fix to read sld:Rotation when does not have ogc sub tags |
|
Nice work @luipir |
|
If you have 1 minute more, there are two minor and irrelevant typos. |
| if ( elem.hasChildNodes() && | ||
| elem.firstChild().nodeType() == QDomNode::TextNode ) | ||
| { | ||
| function = elem.firstChild().nodeValue(); |
There was a problem hiding this comment.
Doesn't this need to be sent through QgsOgcUtils::expressionFromOgcFilter( ... );?
There was a problem hiding this comment.
Or possibly this logic should be moved into expressionFromOgcFilter?
There was a problem hiding this comment.
make sense... I supposed the expressionFromOgcFilter would manage the parsing of an aexpression logic that is more complex. I'll give a check.
There was a problem hiding this comment.
right... is simple and possibile... I'll do it! tnx @m-kuhn to point it out.
In this moment assume that the expression build does not consider a literal constant othan expressed with ogc:Literal
|
@m-kuhn done! I wasn't sure if it was the correct way to proceed. The OGC filter does not consider the possibility to have operators outside ogc tag. Btw I implemented as requested because IMHO there is no a correct semantic solution. |
|
just a note... code for 2.18/2.14 is slightly different. due to different api on QgsExpression where there is not setExpression method introduced in Master |
Added fix to read correctly sld:Rotation tags from SLD