[mesh] mesh frame editing part-2 - start, commit, roll back and cancel #43982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcloarec
added
Feature
Mesh
nyalldawson
reviewed
Jun 29, 2021
nyalldawson
reviewed
Jun 30, 2021
|
@nyalldawson , thanks for this detailed review! |
nyalldawson
reviewed
Jul 1, 2021
|
Thanks @vcloarec -- I'm happy with the API changes now 👍 . I'll let @PeterPetrik / @wonder-sk review the mesh-specific changes |
zacharlie
added
the
Changelog
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scope of the QEP qgis/QGIS-Enhancement-Proposals#228, this PR allows the user of mesh layers to start editing, save, roll back or cancel editing, in the same way as vector layers.