Fix drag and drop to GDB results in columns shifted by one

[nyalldawson]

Fixes #51435

@rouault I'd love your thoughts here . While it works, I don't like this proposed fix and don't think this logic really should be in a place like this.

[rouault]

@nyalldawson I've an additional tuning to your pull request as a pull request on yours at nyalldawson#36

I've also done a fix in the OpenFileGDB driver in OSGeo/gdal#7147. This is the same as what GeoPackage does when creating a field with the name of the FID column.
I'm not fully satisfied with having to put such hacks in drivers. Ideally QGIS should detect that it tries to create an attribute column with the same name as the FID column, and deal with that by moving the content of that attribute column to the FID special attribute. I've looked a bit at changing that but that looked more intimating than doing the fix/workaround in the OpenFileGDB driver

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[rouault]

looks good to me to be merged

[agiudiceandrea]

@nyalldawson @rouault it seems the issue is not yet completely fixed: see #52017 (comment)

[agiudiceandrea]

Hi @nyalldawson, any news about the complete fix of the issue, since it seems it is not yet completely fixed as reported in #52017 (comment)?