Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor options panel within the project properties dialog #52329

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Mar 21, 2023

Description

This PR builds on top of the core sensors framework (#52297) and adds the first part of the GUI interface: a sensor table widget that displays registered sensors within a project with actions to connect and disconnect from sensors. The table is accessible via a new sensors panel in the project properties dialog:

image

To avoid a large PR, I'll open another one after this is reviewed covering sensor creation + configuration GUI (see #52376)

Sponsored by Sevenson Environmental Services.

@nirvn nirvn added the Feature label Mar 21, 2023
@github-actions github-actions bot added this to the 3.32.0 milestone Mar 21, 2023
@nirvn nirvn force-pushed the sensors_framework_2 branch 4 times, most recently from 87f9b51 to 678f1a8 Compare March 24, 2023 09:08
@nirvn nirvn added the GUI/UX Related to QGIS application GUI or User Experience label Mar 24, 2023
@nirvn nirvn changed the title Sensors docker widget to list and connect/disconnect sensors Sensors docker widget Mar 24, 2023
src/core/sensor/qgssensormodel.cpp Outdated Show resolved Hide resolved
src/core/sensor/qgssensormodel.cpp Outdated Show resolved Hide resolved
src/core/sensor/qgssensormodel.cpp Outdated Show resolved Hide resolved
src/core/sensor/qgssensormodel.cpp Show resolved Hide resolved
src/core/sensor/qgssensormodel.cpp Outdated Show resolved Hide resolved
src/core/sensor/qgssensormodel.cpp Outdated Show resolved Hide resolved
src/core/sensor/qgssensormodel.cpp Outdated Show resolved Hide resolved
src/core/sensor/qgssensormodel.h Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator

@nirvn the code is looking good, but I'm not convinced a dock widget is the right approach here. I think it should instead be a tab in the Project Properties dialog, since it's all project-level configuration.

If the live readout is desirable in a non-blocking dock then I'd implement that as a plugin.

@nirvn nirvn changed the title Sensors docker widget Sensor options panel within the project properties dialog Mar 26, 2023
@nirvn
Copy link
Contributor Author

nirvn commented Mar 26, 2023

@nyalldawson , review addressed. I've moved the sensors table within a new sensors panel in the project properties. We can revisit the idea of a sensors dock (or another form of UI/UX within the main window) to handle sensor activation/deactivation and value later.

@nirvn nirvn merged commit 346abae into qgis:master Mar 28, 2023
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jun 17, 2023
@qgis-bot
Copy link
Collaborator

@nirvn

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants