-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensor options panel within the project properties dialog #52329
Conversation
87f9b51
to
678f1a8
Compare
@nirvn the code is looking good, but I'm not convinced a dock widget is the right approach here. I think it should instead be a tab in the Project Properties dialog, since it's all project-level configuration. If the live readout is desirable in a non-blocking dock then I'd implement that as a plugin. |
678f1a8
to
6d798de
Compare
@nyalldawson , review addressed. I've moved the sensors table within a new sensors panel in the project properties. We can revisit the idea of a sensors dock (or another form of UI/UX within the main window) to handle sensor activation/deactivation and value later. |
6d798de
to
ab3bede
Compare
ab3bede
to
00b53e7
Compare
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
Description
This PR builds on top of the core sensors framework (#52297) and adds the first part of the GUI interface: a sensor table widget that displays registered sensors within a project with actions to connect and disconnect from sensors. The table is accessible via a new sensors panel in the project properties dialog:
To avoid a large PR, I'll open another one after this is reviewed covering sensor creation + configuration GUI (see #52376)
Sponsored by Sevenson Environmental Services.