Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on ArchLinux with recent version of protobuf #53962

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

pblottiere
Copy link
Member

@github-actions github-actions bot added this to the 3.34.0 milestone Jul 27, 2023
@pblottiere pblottiere added the Build/Install Related to compiling or installing QGIS label Jul 27, 2023
@lbartoletti lbartoletti self-requested a review July 27, 2023 10:51
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@lbartoletti lbartoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or fix the CI?

CMakeLists.txt Outdated Show resolved Hide resolved
@wulu90
Copy link
Contributor

wulu90 commented Jul 31, 2023

I aslo build QGIS in ArchLinux, fix build only use find_package Config Mode.

the new way use Protobuf is just add .proto file as last parameter to add_library() function.

add_library(qgis_core ${LIBRARY_TYPE} ${QGIS_CORE_SRCS} ${QGIS_CORE_HDRS} ${QGIS_CORE_PRIVATE_HDRS} ${IMAGE_RCCS} vectortile/vector_tile.proto )
target_link_libraries(qgis_core protobuf::libprotobuf-lite)
protobuf_generate(TARGET qgis_core)

Unless Ubuntu update the version of Protobuf package , CI will always fail.

https://github.com/protocolbuffers/protobuf/blob/main/examples/CMakeLists.txt

my commit

CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
@lbartoletti lbartoletti merged commit 447deb9 into qgis:master Aug 10, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build/Install Related to compiling or installing QGIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants