Hide symbology export options when not compatible #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelazJ
commented
Oct 27, 2017
| @@ -57,6 +57,7 @@ QgsVectorLayerSaveAsDialog::QgsVectorLayerSaveAsDialog( QgsVectorLayer *layer, i | |||
| mLayerExtent = layer->extent(); | |||
| } | |||
| setup(); | |||
|
|
|||
| if ( !( options & Symbology ) ) | |||
There was a problem hiding this comment.
i wonder what does return this condition as it seems to be never met
DelazJ
commented
Oct 27, 2017
| fieldsAsDisplayedValues = ( sFormat == QLatin1String( "CSV" ) || sFormat == QLatin1String( "XLS" ) || sFormat == QLatin1String( "XLSX" ) || sFormat == QLatin1String( "ODS" ) ); | ||
| } | ||
|
|
||
| // Show symbology options only for some formats | ||
| if ( sFormat == QLatin1String( "DXF" ) || sFormat == QLatin1String( "KML" ) || sFormat == QLatin1String( "MapInfo File" ) || sFormat == QLatin1String( "MapInfo MIF" ) ) |
There was a problem hiding this comment.
There might be a better way to list the concerned formats, i suppose
|
Refs OSGeo/gdal#260 |
|
Ah, this always bugged me too! Thanks @DelazJ and @nyalldawson for working on this! How to proceed now? Wait for the GDAL capability changes, and then use these too? |
|
I don't know what are the plans but looks like we'll be waiting for gdal cleaner fix. |
|
cleaner fix is gdal >= 2.3 only, so this is acceptable for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vector layer "Save As..." dialog there are options to export features/layer with a symbology. From what i understood it has to do with OGR styles and apply to only some formats. But these options were always shown whatever the selected format.
The PR also hides the "select fields..." frame instead of simply disable it.