[Backport queued_ltr_backports] Raster - paletted: fix slow rendering with huge number of classes

python/PyQt6/core/auto_generated/geometry/qgsrectangle.sip.in

@@ -389,7 +389,11 @@ the specified ``spacing`` between the grid lines.
 
     SIP_PYOBJECT __repr__();
 %MethodCode
-    QString str = QStringLiteral( "<QgsRectangle: %1>" ).arg( sipCpp->asWktCoordinates() );
+    QString str;
+    if ( sipCpp->isNull() )
+      str = QStringLiteral( "<QgsRectangle()>" );
+    else
+      str = QStringLiteral( "<QgsRectangle: %1>" ).arg( sipCpp->asWktCoordinates() );
     sipRes = PyUnicode_FromString( str.toUtf8().constData() );
 %End
 

python/PyQt6/core/auto_generated/gps/qgsgpsdetector.sip.in

@@ -23,11 +23,41 @@ Class to detect the GPS port
 #include "qgsgpsdetector.h"
 %End
   public:
-    QgsGpsDetector( const QString &portName );
+
+
+    QgsGpsDetector( const QString &portName = QString(), bool useUnsafeSignals = true );
+%Docstring
+Constructor for QgsGpsDetector.
+
+If ``portName`` is specified, then only devices from the given port will be scanned. Otherwise
+all connection types will be attempted (including internal GPS devices).
+
+Since QGIS 3.38, the ``useUnsafeSignals`` parameter can be set to ``False`` to avoid emitting the
+dangerous and fragile :py:func:`~QgsGpsDetector.detected` signal. This is highly recommended, but is opt-in to avoid
+breaking stable QGIS 3.x API. If ``useUnsafeSignals`` is set to ``False``, only the safe :py:func:`~QgsGpsDetector.connectionDetected` signal
+will be emitted and clients must manually take ownership of the detected connection via a call
+to :py:func:`~QgsGpsDetector.takeConnection`.
+%End
 
 
     ~QgsGpsDetector();
 
+    QgsGpsConnection *takeConnection() /TransferBack/;
+%Docstring
+Returns the detected GPS connection, and removes it from the detector.
+
+The caller takes ownership of the connection. Only the first call to this
+method following a :py:func:`~QgsGpsDetector.connectionDetected` signal will be able to retrieve the
+detected connection -- subsequent calls will return ``None``.
+
+.. warning::
+
+   Do not call this method if the useUnsafeSignals option in the
+   QgsGpsDetector constructor was set to ``True``.
+
+.. versionadded:: 3.38
+%End
+
     static QList< QPair<QString, QString> > availablePorts();
 
   public slots:
@@ -37,14 +67,28 @@ Class to detect the GPS port
 
   signals:
 
+    void connectionDetected();
+%Docstring
+Emitted when a GPS connection is successfully detected.
+
+Call :py:func:`~QgsGpsDetector.takeConnection` to take ownership of the detected connection.
 
-    void detected( QgsGpsConnection *connection );
+.. versionadded:: 3.38
+%End
+
+ void detected( QgsGpsConnection *connection ) /Deprecated/;
 %Docstring
 Emitted when the GPS connection has been detected. A single connection must listen for this signal and
 immediately take ownership of the ``connection`` object.
+
+.. deprecated::
+   This signal is dangerous and extremely unsafe! It is recommended to instead set the ``useUnsafeSignals`` parameter to ``False`` in the QgsGpsDetector constructor and use the safe :py:func:`~QgsGpsDetector.connectionDetected` signal instead.
 %End
 
     void detectionFailed();
+%Docstring
+Emitted when the detector could not find a valid GPS connection.
+%End
 
 };
 

python/console/console.py

@@ -145,8 +145,6 @@ def __init__(self, parent=None):
         QWidget.__init__(self, parent)
         self.setWindowTitle(QCoreApplication.translate("PythonConsole", "Python Console"))
 
-        self.settings = QgsSettings()
-
         self.shell = ShellScintilla(self)
         self.setFocusProxy(self.shell)
         self.shellOut = ShellOutputScintilla(self)
@@ -310,7 +308,7 @@ def __init__(self, parent=None):
         objList = QCoreApplication.translate("PythonConsole", "Object Inspector…")
         self.objectListButton = QAction(self)
         self.objectListButton.setCheckable(True)
-        self.objectListButton.setEnabled(self.settings.value("pythonConsole/enableObjectInsp",
+        self.objectListButton.setEnabled(QgsSettings().value("pythonConsole/enableObjectInsp",
                                                              False, type=bool))
         self.objectListButton.setIcon(QgsApplication.getThemeIcon("console/iconClassBrowserConsole.svg"))
         self.objectListButton.setMenuRole(QAction.PreferencesRole)
@@ -675,7 +673,8 @@ def openScriptFileExtEditor(self):
             QDesktopServices.openUrl(QUrl.fromLocalFile(path))
 
     def openScriptFile(self):
-        lastDirPath = self.settings.value("pythonConsole/lastDirPath", QDir.homePath())
+        settings = QgsSettings()
+        lastDirPath = settings.value("pythonConsole/lastDirPath", QDir.homePath())
         openFileTr = QCoreApplication.translate("PythonConsole", "Open File")
         fileList, selected_filter = QFileDialog.getOpenFileNames(
             self, openFileTr, lastDirPath, "Script file (*.py)")
@@ -691,7 +690,7 @@ def openScriptFile(self):
                     self.tabEditorWidget.newTabEditor(tabName, pyFile)
 
                     lastDirPath = QFileInfo(pyFile).path()
-                    self.settings.setValue("pythonConsole/lastDirPath", pyFile)
+                    settings.setValue("pythonConsole/lastDirPath", pyFile)
                     self.updateTabListScript(pyFile, action='append')
 
     def saveScriptFile(self):
@@ -710,7 +709,7 @@ def saveAsScriptFile(self, index=None):
             index = self.tabEditorWidget.currentIndex()
         if not tabWidget.path:
             fileName = self.tabEditorWidget.tabText(index).replace('*', '') + '.py'
-            folder = self.settings.value("pythonConsole/lastDirPath", QDir.homePath())
+            folder = QgsSettings().value("pythonConsole/lastDirPath", QDir.homePath())
             pathFileName = os.path.join(folder, fileName)
             fileNone = True
         else:
@@ -776,22 +775,24 @@ def updateTabListScript(self, script, action=None):
                 self.tabListScript.append(script)
         else:
             self.tabListScript = []
-        self.settings.setValue("pythonConsole/tabScripts",
+        QgsSettings().setValue("pythonConsole/tabScripts",
                                self.tabListScript)
 
     def saveSettingsConsole(self):
-        self.settings.setValue("pythonConsole/splitterConsole", self.splitter.saveState())
-        self.settings.setValue("pythonConsole/splitterObj", self.splitterObj.saveState())
-        self.settings.setValue("pythonConsole/splitterEditor", self.splitterEditor.saveState())
+        settings = QgsSettings()
+        settings.setValue("pythonConsole/splitterConsole", self.splitter.saveState())
+        settings.setValue("pythonConsole/splitterObj", self.splitterObj.saveState())
+        settings.setValue("pythonConsole/splitterEditor", self.splitterEditor.saveState())
 
         self.shell.writeHistoryFile()
 
     def restoreSettingsConsole(self):
-        storedTabScripts = self.settings.value("pythonConsole/tabScripts", [])
+        settings = QgsSettings()
+        storedTabScripts = settings.value("pythonConsole/tabScripts", [])
         self.tabListScript = storedTabScripts
-        self.splitter.restoreState(self.settings.value("pythonConsole/splitterConsole", QByteArray()))
-        self.splitterEditor.restoreState(self.settings.value("pythonConsole/splitterEditor", QByteArray()))
-        self.splitterObj.restoreState(self.settings.value("pythonConsole/splitterObj", QByteArray()))
+        self.splitter.restoreState(settings.value("pythonConsole/splitterConsole", QByteArray()))
+        self.splitterEditor.restoreState(settings.value("pythonConsole/splitterEditor", QByteArray()))
+        self.splitterObj.restoreState(settings.value("pythonConsole/splitterObj", QByteArray()))
 
 
 if __name__ == '__main__':

python/console/console_editor.py

@@ -26,6 +26,7 @@
 import re
 import sys
 import tempfile
+from typing import Optional
 from functools import partial
 from operator import itemgetter
 from pathlib import Path
@@ -60,10 +61,9 @@ class Editor(QgsCodeEditorPython):
     def __init__(self, parent=None):
         super().__init__(parent)
         self.parent = parent
-        self.path = None
+        self.path: Optional[str] = None
         #  recent modification time
         self.lastModified = 0
-        self.settings = QgsSettings()
 
         self.setMinimumHeight(120)
         self.setVerticalScrollBarPolicy(Qt.ScrollBarAsNeeded)
@@ -186,7 +186,7 @@ def contextMenuEvent(self, e):
             redoAction.setEnabled(True)
         if QApplication.clipboard().text():
             pasteAction.setEnabled(True)
-        if self.settings.value("pythonConsole/enableObjectInsp",
+        if QgsSettings().value("pythonConsole/enableObjectInsp",
                                False, type=bool):
             showCodeInspection.setEnabled(True)
         menu.exec_(self.mapToGlobal(e.pos()))
@@ -239,7 +239,7 @@ def objectListEditor(self):
             self.pythonconsole.objectListButton.setChecked(True)
 
     def shareOnGist(self, is_public):
-        ACCESS_TOKEN = self.settings.value("pythonConsole/accessTokenGithub", '', type=QByteArray)
+        ACCESS_TOKEN = QgsSettings().value("pythonConsole/accessTokenGithub", '', type=QByteArray)
         if not ACCESS_TOKEN:
             msg_text = QCoreApplication.translate(
                 'PythonConsole', 'GitHub personal access token must be generated (see Console Options)')
@@ -307,7 +307,7 @@ def createTempFile(self):
         return name
 
     def runScriptCode(self):
-        autoSave = self.settings.value("pythonConsole/autoSaveScript", False, type=bool)
+        autoSave = QgsSettings().value("pythonConsole/autoSaveScript", False, type=bool)
         tabWidget = self.tabwidget.currentWidget()
         filename = tabWidget.path
         msgEditorBlank = QCoreApplication.translate('PythonConsole',
@@ -404,24 +404,23 @@ def loadFile(self, filename, readOnly=False):
         self.setModified(False)
         self.recolor()
 
-    def save(self, filename=None):
+    def save(self, filename: Optional[str] = None):
         if self.isReadOnly():
             return
 
-        if self.pythonconsole.settings.value("pythonConsole/formatOnSave", False, type=bool):
+        if QgsSettings().value("pythonConsole/formatOnSave", False, type=bool):
             self.reformatCode()
 
-        tabwidget = self.tabwidget
-        index = tabwidget.indexOf(self.parent)
+        index = self.tabwidget.indexOf(self.parent)
         if filename:
             self.path = filename
-        if self.path is None:
+        if not self.path:
             saveTr = QCoreApplication.translate('PythonConsole',
                                                 'Python Console: Save file')
-            folder = self.pythonconsole.settings.value("pythonConsole/lastDirPath", QDir.homePath())
+            folder = QgsSettings().value("pythonConsole/lastDirPath", QDir.homePath())
             self.path, filter = QFileDialog().getSaveFileName(self,
                                                               saveTr,
-                                                              os.path.join(folder, tabwidget.tabText(index).replace('*', '') + '.py'),
+                                                              os.path.join(folder, self.tabwidget.tabText(index).replace('*', '') + '.py'),
                                                               "Script file (*.py)")
             # If the user didn't select a file, abort the save operation
             if not self.path:
@@ -436,15 +435,15 @@ def save(self, filename=None):
         # Need to use newline='' to avoid adding extra \r characters on Windows
         with open(self.path, 'w', encoding='utf-8', newline='') as f:
             f.write(self.text())
-        tabwidget.setTabTitle(index, Path(self.path).name)
-        tabwidget.setTabToolTip(index, self.path)
+        self.tabwidget.setTabTitle(index, Path(self.path).name)
+        self.tabwidget.setTabToolTip(index, self.path)
         self.setModified(False)
         self.pythonconsole.saveFileButton.setEnabled(False)
         self.lastModified = QFileInfo(self.path).lastModified()
         self.pythonconsole.updateTabListScript(self.path, action='append')
-        tabwidget.listObject(self.parent)
-        lastDirPath = str(Path(self.path).parent)
-        self.pythonconsole.settings.setValue("pythonConsole/lastDirPath", lastDirPath)
+        self.tabwidget.listObject(self.parent)
+        QgsSettings().setValue("pythonConsole/lastDirPath",
+                               Path(self.path).parent.as_posix())
 
     def event(self, e):
         """ Used to override the Application shortcuts when the editor has focus """
@@ -553,8 +552,6 @@ def __init__(self, parent):
         super().__init__(parent=None)
         self.parent = parent
 
-        self.settings = QgsSettings()
-
         self.idx = -1
         # Layout for top frame (restore tabs)
         self.layoutTopFrame = QGridLayout(self)
@@ -641,7 +638,7 @@ def __init__(self, parent):
         self.newTabButton.clicked.connect(self.newTabEditor)
 
     def _currentWidgetChanged(self, tab):
-        if self.settings.value("pythonConsole/enableObjectInsp",
+        if QgsSettings().value("pythonConsole/enableObjectInsp",
                                False, type=bool):
             self.listObject(tab)
         self.changeLastDirPath(tab)
@@ -788,7 +785,7 @@ def restoreTabsOrAddNew(self):
         Restore tabs if they are found in the settings. If none are found it will add a new empty tab.
         """
         # Restore scripts from the previous session
-        tabScripts = self.settings.value("pythonConsole/tabScripts", [])
+        tabScripts = QgsSettings().value("pythonConsole/tabScripts", [])
         self.restoreTabList = tabScripts
 
         if self.restoreTabList:
@@ -911,7 +908,7 @@ def listObject(self, tab):
                     self.parent.listClassMethod.addTopLevelItem(msgItem)
 
     def refreshSettingsEditor(self):
-        objInspectorEnabled = self.settings.value("pythonConsole/enableObjectInsp",
+        objInspectorEnabled = QgsSettings().value("pythonConsole/enableObjectInsp",
                                                   False, type=bool)
         listObj = self.parent.objectListButton
         if self.parent.listClassMethod.isVisible():
@@ -926,7 +923,8 @@ def refreshSettingsEditor(self):
     def changeLastDirPath(self, tab):
         tabWidget = self.widget(tab)
         if tabWidget and tabWidget.path:
-            self.settings.setValue("pythonConsole/lastDirPath", tabWidget.path)
+            QgsSettings().setValue("pythonConsole/lastDirPath",
+                                   Path(tabWidget.path).parent.as_posix())
 
     def showMessage(self, text, level=Qgis.Info, timeout=-1, title=""):
         currWidget = self.currentWidget()

python/console/console_output.py

@@ -54,7 +54,7 @@ def write(self, m):
 
         if self.style == "_traceback":
             # Show errors in red
-            stderrColor = QColor(self.sO.settings.value("pythonConsole/stderrFontColor", QColor(self.ERROR_COLOR)))
+            stderrColor = QColor(QgsSettings().value("pythonConsole/stderrFontColor", QColor(self.ERROR_COLOR)))
             self.sO.SendScintilla(QsciScintilla.SCI_STYLESETFORE, 0o01, stderrColor)
             self.sO.SendScintilla(QsciScintilla.SCI_STYLESETITALIC, 0o01, True)
             self.sO.SendScintilla(QsciScintilla.SCI_STYLESETBOLD, 0o01, True)
@@ -122,8 +122,6 @@ def __init__(self, parent=None):
         self.parent = parent
         self.shell = self.parent.shell
 
-        self.settings = QgsSettings()
-
         # Creates layout for message bar
         self.layout = QGridLayout(self)
         self.layout.setContentsMargins(0, 0, 0, 0)

python/console/console_sci.py

@@ -288,8 +288,6 @@ def __init__(self, parent=None):
         self.opening = ['(', '{', '[', "'", '"']
         self.closing = [')', '}', ']', "'", '"']
 
-        self.settings = QgsSettings()
-
         self.setHistoryFilePath(
             os.path.join(QgsApplication.qgisSettingsDirPath(), "console_history.txt"))
 

python/core/auto_generated/geometry/qgsrectangle.sip.in

@@ -389,7 +389,11 @@ the specified ``spacing`` between the grid lines.
 
     SIP_PYOBJECT __repr__();
 %MethodCode
-    QString str = QStringLiteral( "<QgsRectangle: %1>" ).arg( sipCpp->asWktCoordinates() );
+    QString str;
+    if ( sipCpp->isNull() )
+      str = QStringLiteral( "<QgsRectangle()>" );
+    else
+      str = QStringLiteral( "<QgsRectangle: %1>" ).arg( sipCpp->asWktCoordinates() );
     sipRes = PyUnicode_FromString( str.toUtf8().constData() );
 %End