[processing] Fix Output Variant availability #57150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With qgis#54358 [processing] Add a new 'Calculate expression' algorithm for use in models, a processing output type for variant values has been introduced. This output Should be used when the output is a flexible type and may represent any QVariant value, like QgsPoint, and must be available for use as inputs for most parameter types. In ba7bdec, `QgsProcessingOutputVariant::typeName()` is sometimes added in widget wrapper `compatibleParameterTypes` instead of `compatibleOutputTypes`. For example, the `QgsProcessingOutputVariant::typeName()` is in `QgsProcessingPointWidgetWrapper::compatibleParameterTypes()` instead of `QgsProcessingPointWidgetWrapper::compatibleOutputTypes()`, so `QgsPoint` output in a variant could not be used as an input parameter.
rldhont
added
Processing
nyalldawson
approved these changes
Apr 15, 2024
|
Thanks @rldhont ! |
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #54358 [processing] Add a new 'Calculate expression' algorithm for use in models, a processing output type for variant values has been introduced. This output Should be used when the output is a flexible type and may represent any QVariant value, like QgsPoint, and must be available for use as inputs for most parameter types.
In ba7bdec,
QgsProcessingOutputVariant::typeName()is sometimes added in widget wrappercompatibleParameterTypesinstead ofcompatibleOutputTypes. For example, theQgsProcessingOutputVariant::typeName()is inQgsProcessingPointWidgetWrapper::compatibleParameterTypes()instead ofQgsProcessingPointWidgetWrapper::compatibleOutputTypes(), soQgsPointoutput in a variant could not be used as an input parameter.